mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Rollout useShadowNodeStateOnClone in featureflag config (#54921)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54921 Set the default for `useShadowNodeStateOnClone` in featureflags rather than manually overriding it in `ReactNativeFeatureFlagsOverridesOSSStable.h` This rolls out the `useShadowNodeStateOnClone` feature flag to all internal RN apps following rollout in OSS and experimentation in FB4A (https://fb.workplace.com/groups/362274192795505/posts/810523431303910/) Changelog: [Internal] Reviewed By: cipolleschi, lenaic Differential Revision: D89373358 fbshipit-source-id: 15dbd68cd481864c781851031abdc93584edbfdd
This commit is contained in:
1 parent
d25af38453
commit
1ce99461ed
6 files changed
+8
-14
No files matched your search
+2
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<58cb08dbd188ec64d3738f548567bcde>>
|
||||
* @generated SignedSource<<bb85527f5c9affa81a1ea33f2873a957>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -187,7 +187,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean = true
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean = false
|
||||
override fun useShadowNodeStateOnClone(): Boolean = true
|
||||
|
||||
override fun useSharedAnimatedBackend(): Boolean = false
|
||||
|
||||
|
||||
-2
@@ -11,6 +11,4 @@ public class ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android() :
|
||||
ReactNativeNewArchitectureFeatureFlagsDefaults() {
|
||||
|
||||
override fun useFabricInterop(): Boolean = true
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean = true
|
||||
}
|
||||
+2
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5586a2963cb339f4d5241c790da60d62>>
|
||||
* @generated SignedSource<<33cacaaeb6994f78f5a2d9379618e2a0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -356,7 +356,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
}
|
||||
|
||||
bool useShadowNodeStateOnClone() override {
|
||||
return false;
|
||||
return true;
|
||||
}
|
||||
|
||||
bool useSharedAnimatedBackend() override {
|
||||
|
||||
-4
@@ -29,9 +29,5 @@ class ReactNativeFeatureFlagsOverridesOSSStable : public ReactNativeFeatureFlags
|
||||
{
|
||||
return true;
|
||||
}
|
||||
bool useShadowNodeStateOnClone() override
|
||||
{
|
||||
return true;
|
||||
}
|
||||
};
|
||||
} // namespace facebook::react
|
||||
@@ -921,7 +921,7 @@ const definitions: FeatureFlagDefinitions = {
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
useShadowNodeStateOnClone: {
|
||||
defaultValue: false,
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
dateAdded: '2025-04-16',
|
||||
description:
|
||||
@@ -929,7 +929,7 @@ const definitions: FeatureFlagDefinitions = {
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'experimentation',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
ossReleaseStage: 'stable',
|
||||
},
|
||||
useSharedAnimatedBackend: {
|
||||
defaultValue: false,
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b16ca6ca4e47b347e4f5cb8555d3308f>>
|
||||
* @generated SignedSource<<6b37c02e334fb00f22ce27bb787104cc>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -558,7 +558,7 @@ export const useRawPropsJsiValue: Getter<boolean> = createNativeFlagGetter('useR
|
||||
/**
|
||||
* Use the state stored on the source shadow node when cloning it instead of reading in the most recent state on the shadow node family.
|
||||
*/
|
||||
export const useShadowNodeStateOnClone: Getter<boolean> = createNativeFlagGetter('useShadowNodeStateOnClone', false);
|
||||
export const useShadowNodeStateOnClone: Getter<boolean> = createNativeFlagGetter('useShadowNodeStateOnClone', true);
|
||||
/**
|
||||
* Use shared animation backend in C++ Animated
|
||||
*/
|
||||
|
||||
Reference in new issue
Block a user