Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Gracefully handle suspending in DOM configs (#26768)

Browse Source 
Summary:
E.g. if we suspend (throw a promise) in pushStartInstance today we might
have already pushed some chunks (or even child segments potentially). We
should revert back to where we were.

This doesn't usually happen because when we suspend in a component it
doesn't write anything itself, it'll always defer to som host instance
to do the writing.

There was a todo about this already but I'm not 100% sure it's always
safe when suspending. It should be safe when suspending just regularly
because it's just a noop. We might not even want "throwing a promise" in
this mechanism to be supported longer term but for now that's how a
suspend in internals.

DiffTrain build for commit https://github.com/facebook/react/commit/c10010a6a00911fe99452bc561dd47c3e15f4eb8.

Changelog: [Internal]

<< DO NOT EDIT BELOW THIS LINE >>

Reviewed By: christophpurrer

Differential Revision: D45547661

Pulled By: tyao1

fbshipit-source-id: 69654c95f06bc0f056fc8231e41aa395931af228
This commit is contained in:
sebmarkbage
2023-05-05 16:36:15 -07:00
committed by Facebook GitHub Bot
parent 2db8c8f225
commit 896f3c0790
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
f533cee8cb4fb54c170230741eea7902cb41ee06
c10010a6a00911fe99452bc561dd47c3e15f4eb8