From 896f3c0790951d59491eea8e8b72ef66eecb33a9 Mon Sep 17 00:00:00 2001 From: sebmarkbage Date: Fri, 5 May 2023 16:36:15 -0700 Subject: [PATCH] Gracefully handle suspending in DOM configs (#26768) Summary: E.g. if we suspend (throw a promise) in pushStartInstance today we might have already pushed some chunks (or even child segments potentially). We should revert back to where we were. This doesn't usually happen because when we suspend in a component it doesn't write anything itself, it'll always defer to som host instance to do the writing. There was a todo about this already but I'm not 100% sure it's always safe when suspending. It should be safe when suspending just regularly because it's just a noop. We might not even want "throwing a promise" in this mechanism to be supported longer term but for now that's how a suspend in internals. DiffTrain build for commit https://github.com/facebook/react/commit/c10010a6a00911fe99452bc561dd47c3e15f4eb8. Changelog: [Internal] << DO NOT EDIT BELOW THIS LINE >> Reviewed By: christophpurrer Differential Revision: D45547661 Pulled By: tyao1 fbshipit-source-id: 69654c95f06bc0f056fc8231e41aa395931af228 --- packages/react-native/Libraries/Renderer/REVISION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/Libraries/Renderer/REVISION b/packages/react-native/Libraries/Renderer/REVISION index 7483df03919..12ee8d30c47 100644 --- a/packages/react-native/Libraries/Renderer/REVISION +++ b/packages/react-native/Libraries/Renderer/REVISION @@ -1 +1 @@ -f533cee8cb4fb54c170230741eea7902cb41ee06 +c10010a6a00911fe99452bc561dd47c3e15f4eb8