mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix unused parameter warnings in IMountingManager.h (#56488)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56488 Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Reviewed By: javache Differential Revision: D101110289 fbshipit-source-id: ee9bf593b648c6db8e0764613b29e47036fd7df8
This commit is contained in:
1 parent
e8feadea81
commit
8944bb3706
1 file changed
+18
-15
+18
-15
@@ -40,29 +40,32 @@ class IMountingManager {
|
||||
virtual void
|
||||
dispatchCommand(const ShadowView &shadowView, const std::string &commandName, const folly::dynamic &args) = 0;
|
||||
|
||||
virtual void setIsJSResponder(const ShadowView &shadowView, bool isJSResponder, bool blockNativeResponder) {};
|
||||
virtual void
|
||||
setIsJSResponder(const ShadowView & /* shadowView */, bool /* isJSResponder */, bool /* blockNativeResponder */)
|
||||
{
|
||||
}
|
||||
|
||||
virtual void synchronouslyUpdateViewOnUIThread(Tag reactTag, const folly::dynamic &changedProps) {};
|
||||
virtual void synchronouslyUpdateViewOnUIThread(Tag /* reactTag */, const folly::dynamic & /* changedProps */) {}
|
||||
|
||||
virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> &tagToProps) {};
|
||||
virtual void onUpdateShadowTree(const std::unordered_map<Tag, folly::dynamic> & /* tagToProps */) {}
|
||||
|
||||
virtual void initializeAccessibilityManager() {};
|
||||
virtual void initializeAccessibilityManager() {}
|
||||
|
||||
virtual void setAccessibilityFocusedView(Tag viewTag) {};
|
||||
virtual void setAccessibilityFocusedView(Tag /* viewTag */) {}
|
||||
|
||||
virtual void setFocusedView(Tag viewTag) {};
|
||||
virtual void setFocusedView(Tag /* viewTag */) {}
|
||||
|
||||
virtual void clearAccessibilityFocusedView(Tag viewTag) {};
|
||||
virtual void clearAccessibilityFocusedView(Tag /* viewTag */) {}
|
||||
|
||||
virtual void accessibleClickAction(Tag viewTag) {};
|
||||
virtual void accessibleClickAction(Tag /* viewTag */) {}
|
||||
|
||||
virtual void accessibleScrollInDirection(Tag viewTag, int direction) {};
|
||||
virtual void accessibleScrollInDirection(Tag /* viewTag */, int /* direction */) {}
|
||||
|
||||
virtual void accessibleSetText(Tag viewTag, const std::string &text) {};
|
||||
virtual void accessibleSetText(Tag /* viewTag */, const std::string & /* text */) {}
|
||||
|
||||
virtual void clearFocusedView(Tag viewTag) {};
|
||||
virtual void clearFocusedView(Tag /* viewTag */) {}
|
||||
|
||||
virtual void setAfterMountCallback(std::function<void(SurfaceId)> &&onAfterMount) {};
|
||||
virtual void setAfterMountCallback(std::function<void(SurfaceId)> && /* onAfterMount */) {}
|
||||
|
||||
virtual ComponentRegistryFactory getComponentRegistryFactory()
|
||||
{
|
||||
@@ -74,11 +77,11 @@ class IMountingManager {
|
||||
return false;
|
||||
}
|
||||
|
||||
virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor &&schedulerTaskExecutor) noexcept {};
|
||||
virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor && /* schedulerTaskExecutor */) noexcept {}
|
||||
|
||||
virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> listener) noexcept {};
|
||||
virtual void setEventEmitterListener(std::shared_ptr<EventEmitterListener> /* listener */) noexcept {}
|
||||
|
||||
virtual void setUIManager(std::weak_ptr<UIManager> uiManager) noexcept {};
|
||||
virtual void setUIManager(std::weak_ptr<UIManager> /* uiManager */) noexcept {}
|
||||
|
||||
virtual std::shared_ptr<IImageLoader> getImageLoader() noexcept
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user