From 8944bb3706ce5f89568c2c449d7f5f6b5f30c735 Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Mon, 20 Apr 2026 09:05:06 -0700 Subject: [PATCH] Fix unused parameter warnings in IMountingManager.h (#56488) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56488 Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Reviewed By: javache Differential Revision: D101110289 fbshipit-source-id: ee9bf593b648c6db8e0764613b29e47036fd7df8 --- .../renderer/uimanager/IMountingManager.h | 33 ++++++++++--------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h b/packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h index 6c8e9aebbfe..b68da46f54a 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h +++ b/packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h @@ -40,29 +40,32 @@ class IMountingManager { virtual void dispatchCommand(const ShadowView &shadowView, const std::string &commandName, const folly::dynamic &args) = 0; - virtual void setIsJSResponder(const ShadowView &shadowView, bool isJSResponder, bool blockNativeResponder) {}; + virtual void + setIsJSResponder(const ShadowView & /* shadowView */, bool /* isJSResponder */, bool /* blockNativeResponder */) + { + } - virtual void synchronouslyUpdateViewOnUIThread(Tag reactTag, const folly::dynamic &changedProps) {}; + virtual void synchronouslyUpdateViewOnUIThread(Tag /* reactTag */, const folly::dynamic & /* changedProps */) {} - virtual void onUpdateShadowTree(const std::unordered_map &tagToProps) {}; + virtual void onUpdateShadowTree(const std::unordered_map & /* tagToProps */) {} - virtual void initializeAccessibilityManager() {}; + virtual void initializeAccessibilityManager() {} - virtual void setAccessibilityFocusedView(Tag viewTag) {}; + virtual void setAccessibilityFocusedView(Tag /* viewTag */) {} - virtual void setFocusedView(Tag viewTag) {}; + virtual void setFocusedView(Tag /* viewTag */) {} - virtual void clearAccessibilityFocusedView(Tag viewTag) {}; + virtual void clearAccessibilityFocusedView(Tag /* viewTag */) {} - virtual void accessibleClickAction(Tag viewTag) {}; + virtual void accessibleClickAction(Tag /* viewTag */) {} - virtual void accessibleScrollInDirection(Tag viewTag, int direction) {}; + virtual void accessibleScrollInDirection(Tag /* viewTag */, int /* direction */) {} - virtual void accessibleSetText(Tag viewTag, const std::string &text) {}; + virtual void accessibleSetText(Tag /* viewTag */, const std::string & /* text */) {} - virtual void clearFocusedView(Tag viewTag) {}; + virtual void clearFocusedView(Tag /* viewTag */) {} - virtual void setAfterMountCallback(std::function &&onAfterMount) {}; + virtual void setAfterMountCallback(std::function && /* onAfterMount */) {} virtual ComponentRegistryFactory getComponentRegistryFactory() { @@ -74,11 +77,11 @@ class IMountingManager { return false; } - virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor &&schedulerTaskExecutor) noexcept {}; + virtual void setSchedulerTaskExecutor(SchedulerTaskExecutor && /* schedulerTaskExecutor */) noexcept {} - virtual void setEventEmitterListener(std::shared_ptr listener) noexcept {}; + virtual void setEventEmitterListener(std::shared_ptr /* listener */) noexcept {} - virtual void setUIManager(std::weak_ptr uiManager) noexcept {}; + virtual void setUIManager(std::weak_ptr /* uiManager */) noexcept {} virtual std::shared_ptr getImageLoader() noexcept {