mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix action sheet callback invoked more than once on iPad (#33099)
Summary: iOS will sometimes invoke the UIAlertAction handler for the cancel button more than once on iPad. This can be reproduced relatively easily by having a button that opens an action sheet and spam tapping outside the action sheet while it is opening. Since native module callbacks can only be invoked once this causes the app to crash here https://github.com/facebook/react-native/blob/main/ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.mm#L206. ## Changelog [iOS] [Fixed] - Fix action sheet callback invoked more than once on iPad Pull Request resolved: https://github.com/facebook/react-native/pull/33099 Test Plan: Tested on iPad simulator to reproduce the crash and verified that this fixes it. Reviewed By: philIip Differential Revision: D34215327 Pulled By: ShikaSD fbshipit-source-id: 6f406e4df737a57e6dd702dd54260aa72eab31d6
This commit is contained in:
committed by
Facebook GitHub Bot
parent
c1a55c766f
commit
8935d6e697
@@ -118,6 +118,10 @@ RCT_EXPORT_METHOD(showActionSheetWithOptions
|
||||
|
||||
NSInteger index = 0;
|
||||
bool isCancelButtonIndex = false;
|
||||
// The handler for a button might get called more than once when tapping outside
|
||||
// the action sheet on iPad. RCTResponseSenderBlock can only be called once so
|
||||
// keep track of callback invocation here.
|
||||
__block bool callbackInvoked = false;
|
||||
for (NSString *option in buttons) {
|
||||
UIAlertActionStyle style = UIAlertActionStyleDefault;
|
||||
if ([destructiveButtonIndices containsObject:@(index)]) {
|
||||
@@ -131,7 +135,10 @@ RCT_EXPORT_METHOD(showActionSheetWithOptions
|
||||
UIAlertAction *actionButton = [UIAlertAction actionWithTitle:option
|
||||
style:style
|
||||
handler:^(__unused UIAlertAction *action) {
|
||||
callback(@[ @(localIndex) ]);
|
||||
if (!callbackInvoked) {
|
||||
callbackInvoked = true;
|
||||
callback(@[ @(localIndex) ]);
|
||||
}
|
||||
}];
|
||||
if (isCancelButtonIndex) {
|
||||
[actionButton setValue:cancelButtonTintColor forKey:@"titleTextColor"];
|
||||
|
||||
Reference in New Issue
Block a user