Ellipsize single-line TextInput placeholders (#57909)

Summary:
On Android, long `TextInput` placeholders are hard-clipped with no trailing ellipsis, while iOS truncates with `…`.

Fixes https://github.com/facebook/react-native/issues/29663 (same class of bug as https://github.com/facebook/react-native/pull/55272; uses a correct multiline bitmask check and clears ellipsize when multiline is enabled).

**Repro:** https://github.com/kosmydel/android-ellipsize-repro

| Before | After |
|--------|--------|
| <img width="400" alt="image" src="https://github.com/user-attachments/assets/583a8323-03ae-4075-a662-a4c92e8fec9e" /> |<img width="400" alt="image" src="https://github.com/user-attachments/assets/ece0f350-2349-4244-b7c8-56acd7d15e91" /> |

## Changelog

[Android] [Fixed] - Ellipsize long single-line TextInput placeholders to match iOS

Pull Request resolved: https://github.com/react/react-native/pull/57909

Test Plan:
- Unit: `ReactTextInputPropertyTest` — placeholder sets `TruncateAt.END`; toggling `multiline` clears/restores ellipsize
- Manual: https://github.com/kosmydel/android-ellipsize-repro
  - Single-line constrained `TextInput` with a long placeholder → trailing `…`
  - Short placeholder unchanged
  - `multiline={true}` with a long placeholder → still wraps
  - Toggle `multiline` false → true → false → ellipsize restored

Reviewed By: christophpurrer

Differential Revision: D115724716

Pulled By: Abbondanzo

fbshipit-source-id: a267626a4b8d78d5e853729c46400b88a107d53a
This commit is contained in:
Jakub Kosmydel authored and meta-codesync[bot] committed 2026-08-12 11:57:07 -07:00
1 parent 7cdac2a15c
commit 7f18ad0f84
2 files changed
+29

No files matched your search

@@ -614,6 +614,8 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
}
wasMultiline = isMultiline
updatePlaceholderEllipsize()
// We override the KeyListener so that all keys on the soft input keyboard as well as hardware
// keyboards work. Some KeyListeners like DigitsKeyListener will display the keyboard but not
// accept all input from it
@@ -629,6 +631,16 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
this.placeholder = placeholder
hint = placeholder
}
updatePlaceholderEllipsize()
}
private fun updatePlaceholderEllipsize() {
ellipsize =
if (!isMultiline) {
TextUtils.TruncateAt.END
} else {
null
}
}
public fun setFontFamily(fontFamily: String?) {
@@ -19,6 +19,7 @@ import android.text.InputType
import android.text.Layout
import android.text.SpannableString
import android.text.Spanned
import android.text.TextUtils
import android.util.DisplayMetrics
import android.view.Gravity
import android.view.View
@@ -198,9 +199,25 @@ class ReactTextInputPropertyTest {
manager.updateProperties(view, buildStyles("placeholder", "sometext"))
assertThat(view.hint).isEqualTo("sometext")
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
manager.updateProperties(view, buildStyles("placeholder", null))
assertThat(view.hint).isNull()
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
}
@Test
fun testPlaceholderEllipsizeRespectsMultiline() {
manager.updateProperties(view, buildStyles("placeholder", "a very long placeholder string"))
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
manager.updateProperties(view, buildStyles("multiline", true))
view.commitStagedInputType()
assertThat(view.ellipsize).isNull()
manager.updateProperties(view, buildStyles("multiline", false))
view.commitStagedInputType()
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
}
@Test