From 7f18ad0f8486bf90cc77c38ee1097250218f7f8e Mon Sep 17 00:00:00 2001 From: Jakub Kosmydel Date: Wed, 12 Aug 2026 11:57:07 -0700 Subject: [PATCH] Ellipsize single-line TextInput placeholders (#57909) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: On Android, long `TextInput` placeholders are hard-clipped with no trailing ellipsis, while iOS truncates with `…`. Fixes https://github.com/facebook/react-native/issues/29663 (same class of bug as https://github.com/facebook/react-native/pull/55272; uses a correct multiline bitmask check and clears ellipsize when multiline is enabled). **Repro:** https://github.com/kosmydel/android-ellipsize-repro | Before | After | |--------|--------| | image |image | ## Changelog [Android] [Fixed] - Ellipsize long single-line TextInput placeholders to match iOS Pull Request resolved: https://github.com/react/react-native/pull/57909 Test Plan: - Unit: `ReactTextInputPropertyTest` — placeholder sets `TruncateAt.END`; toggling `multiline` clears/restores ellipsize - Manual: https://github.com/kosmydel/android-ellipsize-repro - Single-line constrained `TextInput` with a long placeholder → trailing `…` - Short placeholder unchanged - `multiline={true}` with a long placeholder → still wraps - Toggle `multiline` false → true → false → ellipsize restored Reviewed By: christophpurrer Differential Revision: D115724716 Pulled By: Abbondanzo fbshipit-source-id: a267626a4b8d78d5e853729c46400b88a107d53a --- .../react/views/textinput/ReactEditText.kt | 12 ++++++++++++ .../textinput/ReactTextInputPropertyTest.kt | 17 +++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt index 9bb938f8b03..e27330c8714 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt @@ -614,6 +614,8 @@ public open class ReactEditText public constructor(context: Context) : AppCompat } wasMultiline = isMultiline + updatePlaceholderEllipsize() + // We override the KeyListener so that all keys on the soft input keyboard as well as hardware // keyboards work. Some KeyListeners like DigitsKeyListener will display the keyboard but not // accept all input from it @@ -629,6 +631,16 @@ public open class ReactEditText public constructor(context: Context) : AppCompat this.placeholder = placeholder hint = placeholder } + updatePlaceholderEllipsize() + } + + private fun updatePlaceholderEllipsize() { + ellipsize = + if (!isMultiline) { + TextUtils.TruncateAt.END + } else { + null + } } public fun setFontFamily(fontFamily: String?) { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt index b79e6249e9d..4a6f6cc7560 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt @@ -19,6 +19,7 @@ import android.text.InputType import android.text.Layout import android.text.SpannableString import android.text.Spanned +import android.text.TextUtils import android.util.DisplayMetrics import android.view.Gravity import android.view.View @@ -198,9 +199,25 @@ class ReactTextInputPropertyTest { manager.updateProperties(view, buildStyles("placeholder", "sometext")) assertThat(view.hint).isEqualTo("sometext") + assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END) manager.updateProperties(view, buildStyles("placeholder", null)) assertThat(view.hint).isNull() + assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END) + } + + @Test + fun testPlaceholderEllipsizeRespectsMultiline() { + manager.updateProperties(view, buildStyles("placeholder", "a very long placeholder string")) + assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END) + + manager.updateProperties(view, buildStyles("multiline", true)) + view.commitStagedInputType() + assertThat(view.ellipsize).isNull() + + manager.updateProperties(view, buildStyles("multiline", false)) + view.commitStagedInputType() + assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END) } @Test