Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update comments for ~ShadowNodeWrapper() and ~ShadowNodeListWrapper() (#45357)

Browse Source 
Summary:
This PR updates the comments for `~ShadowNodeWrapper()` and `~ShadowNodeListWrapper()` to align them with the actual implementation that now uses `jsi::NativeState` instead of `jsi::HostObject`.

## Changelog:

[GENERAL] [FIXED] - Updated comments for `~ShadowNodeWrapper()` and `~ShadowNodeListWrapper()`

Pull Request resolved: https://github.com/facebook/react-native/pull/45357

Reviewed By: sammy-SC

Differential Revision: D59578988

Pulled By: javache

fbshipit-source-id: 1c46ce8407fc8b337f3a6762caee3b2e0e1edfc6
This commit is contained in:
Tomek Zawadzki
2024-07-10 04:57:42 -07:00
committed by Facebook GitHub Bot
parent 8f98c58d38
commit 778fcecf35
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp
+1 -1
View File
@@ -410,7 +410,7 @@ SharedDebugStringConvertibleList ShadowNode::getDebugProps() const {
}
#endif
// Explicitly define destructors here, as they need to exist in order to act as
// Explicitly define destructors here, as they have to exist in order to act as
// a "key function" for the ShadowNodeWrapper class -- this allows for RTTI to
// work properly across dynamic library boundaries (i.e. dynamic_cast that is
// used by getNativeState method)
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
+4 -4
View File
@@ -36,10 +36,10 @@ std::unique_ptr<facebook::react::LeakChecker> constructLeakCheckerIfNeeded(
namespace facebook::react {
// Explicitly define destructors here, as they to exist in order to act as a
// "key function" for the ShadowNodeWrapper class -- this allow for RTTI to work
// properly across dynamic library boundaries (i.e. dynamic_cast that is used by
// isHostObject method)
// Explicitly define destructors here, as they have to exist in order to act as
// a "key function" for the ShadowNodeWrapper class -- this allows for RTTI to
// work properly across dynamic library boundaries (i.e. dynamic_cast that is
// used by getNativeState method)
ShadowNodeListWrapper::~ShadowNodeListWrapper() = default;
UIManager::UIManager(