From 778fcecf357b92f8dd5bab07914aa8563796d0f7 Mon Sep 17 00:00:00 2001 From: Tomek Zawadzki Date: Wed, 10 Jul 2024 04:57:42 -0700 Subject: [PATCH] Update comments for `~ShadowNodeWrapper()` and `~ShadowNodeListWrapper()` (#45357) Summary: This PR updates the comments for `~ShadowNodeWrapper()` and `~ShadowNodeListWrapper()` to align them with the actual implementation that now uses `jsi::NativeState` instead of `jsi::HostObject`. ## Changelog: [GENERAL] [FIXED] - Updated comments for `~ShadowNodeWrapper()` and `~ShadowNodeListWrapper()` Pull Request resolved: https://github.com/facebook/react-native/pull/45357 Reviewed By: sammy-SC Differential Revision: D59578988 Pulled By: javache fbshipit-source-id: 1c46ce8407fc8b337f3a6762caee3b2e0e1edfc6 --- .../ReactCommon/react/renderer/core/ShadowNode.cpp | 2 +- .../ReactCommon/react/renderer/uimanager/UIManager.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp index 68da528464b..438d5fbb9a6 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp @@ -410,7 +410,7 @@ SharedDebugStringConvertibleList ShadowNode::getDebugProps() const { } #endif -// Explicitly define destructors here, as they need to exist in order to act as +// Explicitly define destructors here, as they have to exist in order to act as // a "key function" for the ShadowNodeWrapper class -- this allows for RTTI to // work properly across dynamic library boundaries (i.e. dynamic_cast that is // used by getNativeState method) diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp index 65348e0d409..a97a9acb05f 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp @@ -36,10 +36,10 @@ std::unique_ptr constructLeakCheckerIfNeeded( namespace facebook::react { -// Explicitly define destructors here, as they to exist in order to act as a -// "key function" for the ShadowNodeWrapper class -- this allow for RTTI to work -// properly across dynamic library boundaries (i.e. dynamic_cast that is used by -// isHostObject method) +// Explicitly define destructors here, as they have to exist in order to act as +// a "key function" for the ShadowNodeWrapper class -- this allows for RTTI to +// work properly across dynamic library boundaries (i.e. dynamic_cast that is +// used by getNativeState method) ShadowNodeListWrapper::~ShadowNodeListWrapper() = default; UIManager::UIManager(