Return getConcreteSharedProps() by value

## Summary:

`ConcreteShadowNode::getConcreteSharedProps()` returned `const std::shared_ptr<const ConcreteProps> &` to the result of `std::static_pointer_cast`, which is a temporary, so every caller got a reference to a `shared_ptr` that was already destroyed. It now returns the `shared_ptr` by value. Callers that copy the result, like `auto props = node.getConcreteSharedProps()`, don't need to change. I regenerated the C++ API snapshots for the new signature.

Fixes #59944

## Changelog:

[GENERAL] [FIXED] - `ConcreteShadowNode::getConcreteSharedProps()` no longer returns a dangling reference

## Test Plan:

I compiled the reproducer from the issue against `ConcreteShadowNode.h` with clang and `-Wreturn-stack-address`. Before the change, clang warns "returning reference to local temporary object" at `ConcreteShadowNode.h:147`. After the change there is no warning. I ran `python -m scripts.cxx-api.parser` and the only change to the `ConcreteShadowNode` snapshot entries is the `getConcreteSharedProps()` line.

Differential Revision: D131743393

Pull Request resolved: https://github.com/react/react-native/pull/59957
This commit is contained in:
Lazizbek Ergashev authored and GitHub committed 2026-11-16 11:28:17 +00:00
1 parent 8fccdc53b3
commit 7540fc95ad
13 files changed
+13 -13

No files matched your search

@@ -141,7 +141,7 @@ class ConcreteShadowNode : public BaseShadowNodeT {
* Returns a concrete props object associated with the node, as a shared_ptr.
* Thread-safe after the node is sealed.
*/
const std::shared_ptr<const ConcreteProps> &getConcreteSharedProps() const
std::shared_ptr<const ConcreteProps> getConcreteSharedProps() const
{
react_native_assert(BaseShadowNodeT::props_ && "Props must not be `nullptr`.");
return std::static_pointer_cast<const ConcreteProps>(props_);
@@ -3804,7 +3804,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -3813,6 +3812,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -6901,7 +6901,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -6910,6 +6909,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -3797,7 +3797,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -3806,6 +3805,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -3797,7 +3797,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -3806,6 +3805,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -5711,7 +5711,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -5719,6 +5718,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -8823,7 +8823,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -8831,6 +8830,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -5697,7 +5697,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -5705,6 +5704,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -5704,7 +5704,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -5712,6 +5711,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -2152,7 +2152,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -2160,6 +2159,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -4998,7 +4998,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -5006,6 +5005,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -2145,7 +2145,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -2153,6 +2152,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;
@@ -2145,7 +2145,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const;
public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const;
public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const;
public const std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps>& getConcreteSharedProps() const;
public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps();
public static constexpr facebook::react::ShadowNodeTraits BaseTraits();
public static facebook::react::ComponentHandle Handle();
@@ -2153,6 +2152,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps);
public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr);
public std::shared_ptr<const facebook::react::ConcreteShadowNode::ConcreteProps> getConcreteSharedProps() const;
public using ConcreteEventEmitter = EventEmitterT;
public using ConcreteProps = PropsT;
public using ConcreteState = facebook::react::ConcreteState<StateDataT>;