From 7540fc95ada0efe6e2c5c7d3346d0945515a1abb Mon Sep 17 00:00:00 2001 From: Lazizbek Ergashev Date: Mon, 16 Nov 2026 16:28:17 +0500 Subject: [PATCH] Return getConcreteSharedProps() by value ## Summary: `ConcreteShadowNode::getConcreteSharedProps()` returned `const std::shared_ptr &` to the result of `std::static_pointer_cast`, which is a temporary, so every caller got a reference to a `shared_ptr` that was already destroyed. It now returns the `shared_ptr` by value. Callers that copy the result, like `auto props = node.getConcreteSharedProps()`, don't need to change. I regenerated the C++ API snapshots for the new signature. Fixes #59944 ## Changelog: [GENERAL] [FIXED] - `ConcreteShadowNode::getConcreteSharedProps()` no longer returns a dangling reference ## Test Plan: I compiled the reproducer from the issue against `ConcreteShadowNode.h` with clang and `-Wreturn-stack-address`. Before the change, clang warns "returning reference to local temporary object" at `ConcreteShadowNode.h:147`. After the change there is no warning. I ran `python -m scripts.cxx-api.parser` and the only change to the `ConcreteShadowNode` snapshot entries is the `getConcreteSharedProps()` line. Differential Revision: D131743393 Pull Request resolved: https://github.com/react/react-native/pull/59957 --- .../ReactCommon/react/renderer/core/ConcreteShadowNode.h | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api | 2 +- scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h index 2b2a509b177..5d3ac8c7bde 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h @@ -141,7 +141,7 @@ class ConcreteShadowNode : public BaseShadowNodeT { * Returns a concrete props object associated with the node, as a shared_ptr. * Thread-safe after the node is sealed. */ - const std::shared_ptr &getConcreteSharedProps() const + std::shared_ptr getConcreteSharedProps() const { react_native_assert(BaseShadowNodeT::props_ && "Props must not be `nullptr`."); return std::static_pointer_cast(props_); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 921b4861dad..8dd4714909d 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -3804,7 +3804,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -3813,6 +3812,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api index a207eedcc86..12475b97f00 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api @@ -6901,7 +6901,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -6910,6 +6909,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index 4687eb5b751..6e6ae802397 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -3797,7 +3797,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -3806,6 +3805,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 4687eb5b751..6e6ae802397 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -3797,7 +3797,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -3806,6 +3805,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); public static void initializeDynamicProps(facebook::react::ConcreteShadowNode::UnsharedConcreteProps props, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 8360a9404bf..16137b73c47 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -5711,7 +5711,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -5719,6 +5718,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api index 59da2c6ddb1..26b0c5bd849 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api @@ -8823,7 +8823,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -8831,6 +8830,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index 5b242c3dae4..fbeb0eebd8e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -5697,7 +5697,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -5705,6 +5704,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 28d77a4d071..94b9e942329 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -5704,7 +5704,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -5712,6 +5711,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index 1f658ff7f2d..b8fda8626e4 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -2152,7 +2152,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -2160,6 +2159,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api index ffc811e88ed..e06f00e1464 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api @@ -4998,7 +4998,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -5006,6 +5005,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index c3f7f25e826..53334f060ec 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -2145,7 +2145,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -2153,6 +2152,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index c3f7f25e826..53334f060ec 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -2145,7 +2145,6 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public const facebook::react::ConcreteShadowNode::ConcreteEventEmitter& getConcreteEventEmitter() const; public const facebook::react::ConcreteShadowNode::ConcreteProps& getConcreteProps() const; public const facebook::react::ConcreteShadowNode::ConcreteStateData& getStateData() const; - public const std::shared_ptr& getConcreteSharedProps() const; public static const facebook::react::ConcreteShadowNode::SharedConcreteProps& defaultSharedProps(); public static constexpr facebook::react::ShadowNodeTraits BaseTraits(); public static facebook::react::ComponentHandle Handle(); @@ -2153,6 +2152,7 @@ class facebook::react::ConcreteShadowNode : public BaseShadowNodeT { public static facebook::react::ConcreteShadowNode::ConcreteStateData initialStateData(const facebook::react::Props::Shared&, const facebook::react::ShadowNodeFamily::Shared&, const facebook::react::ComponentDescriptor&); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::Props::Shared& baseProps); public static facebook::react::ConcreteShadowNode::UnsharedConcreteProps Props(const facebook::react::PropsParserContext& context, const facebook::react::RawProps& rawProps, const facebook::react::Props::Shared& baseProps = nullptr); + public std::shared_ptr getConcreteSharedProps() const; public using ConcreteEventEmitter = EventEmitterT; public using ConcreteProps = PropsT; public using ConcreteState = facebook::react::ConcreteState;