Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup installJSBindingWithRuntimeExecutor (#38541)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38541

Changelog: [iOS][Breaking]

we can just delete this, replacing the callsite w/ `installJSBindings` is straightforward

Reviewed By: mdvacca, cipolleschi

Differential Revision: D47620027

fbshipit-source-id: 8bb651dc14c6120f06a61326c63b15d1e3d68e9b
This commit is contained in:
Phillip Pan
2023-07-22 23:21:22 -07:00
committed by Facebook GitHub Bot
parent 89ff3ac6cd
commit 74feb4cf6c
2 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h
-5
View File
@@ -65,11 +65,6 @@
- (void)installJSBindings:(facebook::jsi::Runtime &)runtime;
/**
* @deprecated: use installJSBindings instead
*/
- (void)installJSBindingWithRuntimeExecutor:(facebook::react::RuntimeExecutor &)runtimeExecutor;
- (void)invalidate;
@end
packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm
-11
View File
@@ -962,17 +962,6 @@ static Class getFallbackClassFromName(const char *name)
}
}
/**
* @deprecated: use installJSBindings instead
*/
- (void)installJSBindingWithRuntimeExecutor:(facebook::react::RuntimeExecutor &)runtimeExecutor
{
// jsi::Runtime doesn't exist when attached to Chrome debugger.
if (runtimeExecutor) {
runtimeExecutor([self](facebook::jsi::Runtime &runtime) { [self installJSBindings:runtime]; });
}
}
#pragma mark RCTTurboModuleRegistry
- (id)moduleForName:(const char *)moduleName