From 74feb4cf6c21d3acd9f7da54977c4afccaa6285a Mon Sep 17 00:00:00 2001 From: Phillip Pan Date: Sat, 22 Jul 2023 23:21:22 -0700 Subject: [PATCH] cleanup installJSBindingWithRuntimeExecutor (#38541) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38541 Changelog: [iOS][Breaking] we can just delete this, replacing the callsite w/ `installJSBindings` is straightforward Reviewed By: mdvacca, cipolleschi Differential Revision: D47620027 fbshipit-source-id: 8bb651dc14c6120f06a61326c63b15d1e3d68e9b --- .../platform/ios/ReactCommon/RCTTurboModuleManager.h | 5 ----- .../platform/ios/ReactCommon/RCTTurboModuleManager.mm | 11 ----------- 2 files changed, 16 deletions(-) diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h index 2130bb136ac..1ef120d83dc 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h +++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h @@ -65,11 +65,6 @@ - (void)installJSBindings:(facebook::jsi::Runtime &)runtime; -/** - * @deprecated: use installJSBindings instead - */ -- (void)installJSBindingWithRuntimeExecutor:(facebook::react::RuntimeExecutor &)runtimeExecutor; - - (void)invalidate; @end diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm index 283eb4a2be8..6c6570b842b 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm +++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm @@ -962,17 +962,6 @@ static Class getFallbackClassFromName(const char *name) } } -/** - * @deprecated: use installJSBindings instead - */ -- (void)installJSBindingWithRuntimeExecutor:(facebook::react::RuntimeExecutor &)runtimeExecutor -{ - // jsi::Runtime doesn't exist when attached to Chrome debugger. - if (runtimeExecutor) { - runtimeExecutor([self](facebook::jsi::Runtime &runtime) { [self installJSBindings:runtime]; }); - } -} - #pragma mark RCTTurboModuleRegistry - (id)moduleForName:(const char *)moduleName