Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use needsInvalidateLayer, not _needsInvalidateLayer for filter and box shadow (#45622)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45622

The rest of these props setters opts to use `needsInvalidateLayer`, not `_needsInvalidateLayer` the latter of which is a instance variable. This change no effect since we set `_needsInvalidateLayer` to the or of both below, but we should be consistent with the rest of the logic here.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D60144215

fbshipit-source-id: b4b863d964a688c1cb9f6fada626d390681d1542
This commit is contained in:
Joe Vilches
2024-07-24 14:00:05 -07:00
committed by Facebook GitHub Bot
parent e42533294b
commit 6fc3d359b5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
+2 -2
View File
@@ -401,7 +401,7 @@ using namespace facebook::react;
// `filter`
if (oldViewProps.filter != newViewProps.filter) {
_needsInvalidateLayer = YES;
needsInvalidateLayer = YES;
}
// `mixBlendMode`
@@ -460,7 +460,7 @@ using namespace facebook::react;
// `boxShadow`
if (oldViewProps.boxShadow != newViewProps.boxShadow) {
_needsInvalidateLayer = YES;
needsInvalidateLayer = YES;
}
_needsInvalidateLayer = _needsInvalidateLayer || needsInvalidateLayer;