From 6fc3d359b579dae1927fcdadcb179cf517ddf39a Mon Sep 17 00:00:00 2001 From: Joe Vilches Date: Wed, 24 Jul 2024 14:00:05 -0700 Subject: [PATCH] Use needsInvalidateLayer, not _needsInvalidateLayer for filter and box shadow (#45622) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45622 The rest of these props setters opts to use `needsInvalidateLayer`, not `_needsInvalidateLayer` the latter of which is a instance variable. This change no effect since we set `_needsInvalidateLayer` to the or of both below, but we should be consistent with the rest of the logic here. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D60144215 fbshipit-source-id: b4b863d964a688c1cb9f6fada626d390681d1542 --- .../Mounting/ComponentViews/View/RCTViewComponentView.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm index 1929a6c57de..41a9eb10601 100644 --- a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm +++ b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm @@ -401,7 +401,7 @@ using namespace facebook::react; // `filter` if (oldViewProps.filter != newViewProps.filter) { - _needsInvalidateLayer = YES; + needsInvalidateLayer = YES; } // `mixBlendMode` @@ -460,7 +460,7 @@ using namespace facebook::react; // `boxShadow` if (oldViewProps.boxShadow != newViewProps.boxShadow) { - _needsInvalidateLayer = YES; + needsInvalidateLayer = YES; } _needsInvalidateLayer = _needsInvalidateLayer || needsInvalidateLayer;