Fabric: Enabling WITH_FBSYSTRACE for Fabric code

Summary:
Systraces were disabled a year ago in D14019272 because we suspected they can negatively affect perf. We don't think this is the case anymore.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D19786284

fbshipit-source-id: 185ed45b134fdcadf131cfddfcf8faf37537a684
This commit is contained in:
Valentin Shergin
2020-02-07 10:14:10 -08:00
committed by Facebook Github Bot
parent edfdafc7a1
commit 6e7369e1fd
6 changed files with 6 additions and 12 deletions
+1 -2
View File
@@ -42,8 +42,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],
@@ -42,8 +42,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],
+1 -2
View File
@@ -49,8 +49,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],
+1 -2
View File
@@ -45,8 +45,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],
+1 -2
View File
@@ -46,8 +46,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],
+1 -2
View File
@@ -45,8 +45,7 @@ rn_xplat_cxx_library(
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
# Systraces are temporary disabled.
# "-DWITH_FBSYSTRACE=1",
"-DWITH_FBSYSTRACE=1",
],
tests = [":tests"],
visibility = ["PUBLIC"],