From 6e7369e1fd179c24f42f644d5df431feaff33397 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Fri, 7 Feb 2020 10:12:13 -0800 Subject: [PATCH] Fabric: Enabling `WITH_FBSYSTRACE` for Fabric code Summary: Systraces were disabled a year ago in D14019272 because we suspected they can negatively affect perf. We don't think this is the case anymore. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D19786284 fbshipit-source-id: 185ed45b134fdcadf131cfddfcf8faf37537a684 --- ReactCommon/fabric/components/root/BUCK | 3 +-- ReactCommon/fabric/components/unimplementedview/BUCK | 3 +-- ReactCommon/fabric/components/view/BUCK | 3 +-- ReactCommon/fabric/element/BUCK | 3 +-- ReactCommon/fabric/mounting/BUCK | 3 +-- ReactCommon/fabric/uimanager/BUCK | 3 +-- 6 files changed, 6 insertions(+), 12 deletions(-) diff --git a/ReactCommon/fabric/components/root/BUCK b/ReactCommon/fabric/components/root/BUCK index 1cc61587df3..ffa7b6df2d3 100644 --- a/ReactCommon/fabric/components/root/BUCK +++ b/ReactCommon/fabric/components/root/BUCK @@ -42,8 +42,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"], diff --git a/ReactCommon/fabric/components/unimplementedview/BUCK b/ReactCommon/fabric/components/unimplementedview/BUCK index f937d6e6d0a..87ecb38455d 100644 --- a/ReactCommon/fabric/components/unimplementedview/BUCK +++ b/ReactCommon/fabric/components/unimplementedview/BUCK @@ -42,8 +42,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"], diff --git a/ReactCommon/fabric/components/view/BUCK b/ReactCommon/fabric/components/view/BUCK index 86105da371e..9e81153fe5f 100644 --- a/ReactCommon/fabric/components/view/BUCK +++ b/ReactCommon/fabric/components/view/BUCK @@ -49,8 +49,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"], diff --git a/ReactCommon/fabric/element/BUCK b/ReactCommon/fabric/element/BUCK index 33af61f89c1..f93af8da382 100644 --- a/ReactCommon/fabric/element/BUCK +++ b/ReactCommon/fabric/element/BUCK @@ -45,8 +45,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"], diff --git a/ReactCommon/fabric/mounting/BUCK b/ReactCommon/fabric/mounting/BUCK index fad72eb8e5e..0dc3fd6f3de 100644 --- a/ReactCommon/fabric/mounting/BUCK +++ b/ReactCommon/fabric/mounting/BUCK @@ -46,8 +46,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"], diff --git a/ReactCommon/fabric/uimanager/BUCK b/ReactCommon/fabric/uimanager/BUCK index 01fe4e31f32..85cb5840a11 100644 --- a/ReactCommon/fabric/uimanager/BUCK +++ b/ReactCommon/fabric/uimanager/BUCK @@ -45,8 +45,7 @@ rn_xplat_cxx_library( platforms = (ANDROID, APPLE, CXX), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", - # Systraces are temporary disabled. - # "-DWITH_FBSYSTRACE=1", + "-DWITH_FBSYSTRACE=1", ], tests = [":tests"], visibility = ["PUBLIC"],