Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java (#50351)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50351

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D71979584

fbshipit-source-id: 52e29ac578edcbcd9bd14de4d327564d54f421cf
This commit is contained in:
Gijs Weterings
2025-04-03 08:01:59 -07:00
committed by Facebook GitHub Bot
parent 8f5aaf13b2
commit 6d96f70abc
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java
+4
View File
@@ -130,6 +130,7 @@ public class DialogModule extends NativeDialogManagerAndroidSpec implements Life
}
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void onDismiss(DialogInterface dialog) {
if (!mCallbackConsumed) {
if (getReactApplicationContext().hasActiveReactInstance()) {
@@ -198,8 +199,11 @@ public class DialogModule extends NativeDialogManagerAndroidSpec implements Life
}
if (options.hasKey(KEY_ITEMS)) {
ReadableArray items = options.getArray(KEY_ITEMS);
// NULLSAFE_FIXME[Nullable Dereference]
CharSequence[] itemsArray = new CharSequence[items.size()];
// NULLSAFE_FIXME[Nullable Dereference]
for (int i = 0; i < items.size(); i++) {
// NULLSAFE_FIXME[Nullable Dereference]
itemsArray[i] = items.getString(i);
}
args.putCharSequenceArray(AlertFragment.ARG_ITEMS, itemsArray);