From 6d96f70abcd7e993912253a568d4ca1edd36fee6 Mon Sep 17 00:00:00 2001 From: Gijs Weterings Date: Thu, 3 Apr 2025 08:01:59 -0700 Subject: [PATCH] Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java (#50351) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50351 Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71979584 fbshipit-source-id: 52e29ac578edcbcd9bd14de4d327564d54f421cf --- .../java/com/facebook/react/modules/dialog/DialogModule.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java index d99f152fe8f..9d3f15ad6a2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java @@ -130,6 +130,7 @@ public class DialogModule extends NativeDialogManagerAndroidSpec implements Life } @Override + // NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation] public void onDismiss(DialogInterface dialog) { if (!mCallbackConsumed) { if (getReactApplicationContext().hasActiveReactInstance()) { @@ -198,8 +199,11 @@ public class DialogModule extends NativeDialogManagerAndroidSpec implements Life } if (options.hasKey(KEY_ITEMS)) { ReadableArray items = options.getArray(KEY_ITEMS); + // NULLSAFE_FIXME[Nullable Dereference] CharSequence[] itemsArray = new CharSequence[items.size()]; + // NULLSAFE_FIXME[Nullable Dereference] for (int i = 0; i < items.size(); i++) { + // NULLSAFE_FIXME[Nullable Dereference] itemsArray[i] = items.getString(i); } args.putCharSequenceArray(AlertFragment.ARG_ITEMS, itemsArray);