Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken Gradle Sync when opening the project with Android Studio (#39412)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39412

This fixes an issue that I got reported by users attempting to open the react-native GitHub project in Android Studio.

The error is:
```
  Cannot specify include directories for target "react_codegen_AppSpecs" which is  not built by this project.
```

Changelog:
[Internal] [Changed] - Fix broken Gradle Sync when opening the project with Android Studio

Reviewed By: huntie

Differential Revision: D49189331

fbshipit-source-id: 632063a7e1afc53284231be263bec352dc7057c5
This commit is contained in:
Nicola Corti
2023-09-12 08:33:54 -07:00
committed by Facebook GitHub Bot
parent 67387c3c91
commit 67e794ab40
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/rn-tester/NativeCxxModuleExample/CMakeLists.txt
+10 -3
View File
@@ -20,10 +20,17 @@ file(GLOB nativecxxmoduleexample_SRC CONFIGURE_DEPENDS *.cpp)
add_library(nativecxxmoduleexample STATIC ${nativecxxmoduleexample_SRC})
target_include_directories(nativecxxmoduleexample PUBLIC .)
target_include_directories(react_codegen_AppSpecs PUBLIC .)
target_link_libraries(nativecxxmoduleexample
fbjni
jsi
react_nativemodule_core
react_codegen_AppSpecs)
react_nativemodule_core)
# For Gradle Syncs (i.e. when you first open the project in Android Studio),
# the react_codegen_AppSpecs target is not existing yet as it's generated by
# Codegen. Therefore skip the linking with that library if it's missing in the
# CMake dependency Graph. It will be included anyway in the final build.
if (TARGET react_codegen_AppSpecs)
target_include_directories(react_codegen_AppSpecs PUBLIC .)
target_link_libraries(nativecxxmoduleexample react_codegen_AppSpecs)
endif ()