Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implement findDescendantNode without cloning the tree (#39356)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39356

changelog: [internal]

`findDescendantNode` shouldn't clone the tree.

Reviewed By: javache

Differential Revision: D49095341

fbshipit-source-id: 4cd6aa6f9ba0f96d708e6a6c6b0cd55f03d8b5b1
This commit is contained in:
Samuel Susla
2023-09-12 06:55:37 -07:00
committed by Facebook GitHub Bot
parent 2153184c77
commit 67387c3c91
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/mounting/tests/StateReconciliationTest.cpp
+16 -8
View File
@@ -36,23 +36,31 @@ class DummyShadowTreeDelegate : public ShadowTreeDelegate {
bool mountSynchronously) const override{};
};
inline const ShadowNode* findDescendantNode(
namespace {
const ShadowNode* findDescendantNode(
const ShadowNode& shadowNode,
const ShadowNodeFamily& family) {
const ShadowNode* result = nullptr;
shadowNode.cloneTree(family, [&](const ShadowNode& oldShadowNode) {
result = &oldShadowNode;
return oldShadowNode.clone({});
});
return result;
if (&shadowNode.getFamily() == &family) {
return &shadowNode;
}
for (auto childNode : shadowNode.getChildren()) {
auto descendant = findDescendantNode(*childNode, family);
if (descendant != nullptr) {
return descendant;
}
}
return nullptr;
}
inline const ShadowNode* findDescendantNode(
const ShadowNode* findDescendantNode(
const ShadowTree& shadowTree,
const ShadowNodeFamily& family) {
return findDescendantNode(
*shadowTree.getCurrentRevision().rootShadowNode, family);
}
} // namespace
TEST(StateReconciliationTest, testStateReconciliation) {
auto builder = simpleComponentBuilder();