mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Do not remove libjscexecutor.so from release builds (#32932)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/32932 As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Reviewed By: ShikaSD Differential Revision: D33681932 fbshipit-source-id: 5b59fd1fb76c80c191198d65c916bbbd9232c75b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ceb01db25f
commit
574a773f8f
-4
@@ -240,10 +240,6 @@ private fun Project.cleanupVMFiles(
|
||||
} else {
|
||||
// For JSC, delete all the libhermes* files
|
||||
it.include("**/libhermes*.so")
|
||||
// Delete the libjscexecutor from release build
|
||||
if (cleanup) {
|
||||
it.include("**/libjscexecutor.so")
|
||||
}
|
||||
}
|
||||
}
|
||||
.visit { visit ->
|
||||
|
||||
@@ -372,10 +372,6 @@ afterEvaluate {
|
||||
} else {
|
||||
// For JSC, delete all the libhermes* files
|
||||
include "**/libhermes*.so"
|
||||
// Delete the libjscexecutor from release build
|
||||
if (cleanup) {
|
||||
include "**/libjscexecutor.so"
|
||||
}
|
||||
}
|
||||
}.visit { details ->
|
||||
def targetVariant1 = ".*/transforms/[^/]*/${variant.name}/.*"
|
||||
|
||||
Reference in New Issue
Block a user