From 574a773f8f55fe7808fbb672066be8174c64d76d Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 20 Jan 2022 04:18:43 -0800 Subject: [PATCH] Do not remove libjscexecutor.so from release builds (#32932) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/32932 As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Reviewed By: ShikaSD Differential Revision: D33681932 fbshipit-source-id: 5b59fd1fb76c80c191198d65c916bbbd9232c75b --- .../src/main/kotlin/com/facebook/react/TaskConfiguration.kt | 4 ---- react.gradle | 4 ---- 2 files changed, 8 deletions(-) diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt index 8c0c41970f6..30625c53d37 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt @@ -240,10 +240,6 @@ private fun Project.cleanupVMFiles( } else { // For JSC, delete all the libhermes* files it.include("**/libhermes*.so") - // Delete the libjscexecutor from release build - if (cleanup) { - it.include("**/libjscexecutor.so") - } } } .visit { visit -> diff --git a/react.gradle b/react.gradle index 7e9333aaace..0ace9be826f 100644 --- a/react.gradle +++ b/react.gradle @@ -372,10 +372,6 @@ afterEvaluate { } else { // For JSC, delete all the libhermes* files include "**/libhermes*.so" - // Delete the libjscexecutor from release build - if (cleanup) { - include "**/libjscexecutor.so" - } } }.visit { details -> def targetVariant1 = ".*/transforms/[^/]*/${variant.name}/.*"