Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Getting rid of static_pointer_cast in ConcreteShadowNode

Browse Source 
Summary:
`std::static_pointer_cast` has perf overhead where as `static_cast` does not.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D19837695

fbshipit-source-id: 4a257e66813a4a3c757c8ea15ea6ae5e192d1390
This commit is contained in:
Valentin Shergin
2020-02-13 21:05:36 -08:00
committed by Facebook Github Bot
parent 967c9dc7b1
commit 5703abd953
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h
+11 -12
View File
@@ -35,10 +35,10 @@ class ConcreteShadowNode : public ShadowNode {
using ShadowNode::ShadowNode;
using ConcreteProps = PropsT;
using SharedConcreteProps = std::shared_ptr<const PropsT>;
using SharedConcreteProps = std::shared_ptr<PropsT const>;
using ConcreteEventEmitter = EventEmitterT;
using SharedConcreteEventEmitter = std::shared_ptr<const EventEmitterT>;
using SharedConcreteShadowNode = std::shared_ptr<const ConcreteShadowNode>;
using SharedConcreteEventEmitter = std::shared_ptr<EventEmitterT const>;
using SharedConcreteShadowNode = std::shared_ptr<ConcreteShadowNode const>;
using ConcreteState = ConcreteState<StateDataT>;
using ConcreteStateData = StateDataT;
@@ -59,11 +59,10 @@ class ConcreteShadowNode : public ShadowNode {
}
static SharedConcreteProps Props(
const RawProps &rawProps,
const SharedProps &baseProps = nullptr) {
return std::make_shared<const PropsT>(
baseProps ? *std::static_pointer_cast<const PropsT>(baseProps)
: PropsT(),
RawProps const &rawProps,
SharedProps const &baseProps = nullptr) {
return std::make_shared<PropsT const>(
baseProps ? static_cast<PropsT const &>(*baseProps) : PropsT(),
rawProps);
}
@@ -89,7 +88,7 @@ class ConcreteShadowNode : public ShadowNode {
assert(
std::dynamic_pointer_cast<ConcreteProps const>(props_) &&
"Props must be an instance of ConcreteProps class.");
return *static_cast<ConcreteProps const *>(props_.get());
return static_cast<ConcreteProps const &>(*props_);
}
/*
@@ -101,7 +100,7 @@ class ConcreteShadowNode : public ShadowNode {
assert(
std::dynamic_pointer_cast<ConcreteState const>(state_) &&
"State must be an instance of ConcreteState class.");
return std::static_pointer_cast<ConcreteState const>(state_)->getData();
return static_cast<ConcreteState const *>(state_.get())->getData();
}
/*
@@ -124,9 +123,9 @@ class ConcreteShadowNode : public ShadowNode {
better::
small_vector<SpecificShadowNodeT *, kShadowNodeChildrenSmallVectorSize>
children;
for (const auto &childShadowNode : getChildren()) {
for (auto const &childShadowNode : getChildren()) {
auto specificChildShadowNode =
dynamic_cast<const SpecificShadowNodeT *>(childShadowNode.get());
dynamic_cast<SpecificShadowNodeT const *>(childShadowNode.get());
if (specificChildShadowNode) {
children.push_back(
const_cast<SpecificShadowNodeT *>(specificChildShadowNode));