diff --git a/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h b/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h index 80ef750777f..92bad021c49 100644 --- a/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h +++ b/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h @@ -35,10 +35,10 @@ class ConcreteShadowNode : public ShadowNode { using ShadowNode::ShadowNode; using ConcreteProps = PropsT; - using SharedConcreteProps = std::shared_ptr; + using SharedConcreteProps = std::shared_ptr; using ConcreteEventEmitter = EventEmitterT; - using SharedConcreteEventEmitter = std::shared_ptr; - using SharedConcreteShadowNode = std::shared_ptr; + using SharedConcreteEventEmitter = std::shared_ptr; + using SharedConcreteShadowNode = std::shared_ptr; using ConcreteState = ConcreteState; using ConcreteStateData = StateDataT; @@ -59,11 +59,10 @@ class ConcreteShadowNode : public ShadowNode { } static SharedConcreteProps Props( - const RawProps &rawProps, - const SharedProps &baseProps = nullptr) { - return std::make_shared( - baseProps ? *std::static_pointer_cast(baseProps) - : PropsT(), + RawProps const &rawProps, + SharedProps const &baseProps = nullptr) { + return std::make_shared( + baseProps ? static_cast(*baseProps) : PropsT(), rawProps); } @@ -89,7 +88,7 @@ class ConcreteShadowNode : public ShadowNode { assert( std::dynamic_pointer_cast(props_) && "Props must be an instance of ConcreteProps class."); - return *static_cast(props_.get()); + return static_cast(*props_); } /* @@ -101,7 +100,7 @@ class ConcreteShadowNode : public ShadowNode { assert( std::dynamic_pointer_cast(state_) && "State must be an instance of ConcreteState class."); - return std::static_pointer_cast(state_)->getData(); + return static_cast(state_.get())->getData(); } /* @@ -124,9 +123,9 @@ class ConcreteShadowNode : public ShadowNode { better:: small_vector children; - for (const auto &childShadowNode : getChildren()) { + for (auto const &childShadowNode : getChildren()) { auto specificChildShadowNode = - dynamic_cast(childShadowNode.get()); + dynamic_cast(childShadowNode.get()); if (specificChildShadowNode) { children.push_back( const_cast(specificChildShadowNode));