Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Separate RCTLinking from ReactInternal

Browse Source 
Summary:
None of the code inside `ReactInternal` depended on the `RCTLinkingManager` NativeModule. So I extracted `RCTLinking` into its own BUCK target. This will make it easier to make `RCTLinkingManager` TurboModule-compatible.

## Codemod
Everywhere we required `ReactInternal`, we now also require `RCTLinking`:
```
> xbgr -f 'BUCK$' 'ReactInternal"' -l | xargs -I {} sed -i '' $'s|ReactInternal",|ReactInternal",\"fbsource//xplat/js:RCTLinking",|g' $HOME/{}
> xbgr -f 'BUCK$' 'ReactInternalApple"' -l | xargs -I {} sed -i '' $'s|ReactInternalApple",|ReactInternalApple",\"fbsource//xplat/js:RCTLinkingApple",|g' $HOME/{}
> arc f
```

Changelog:
[Internal] - Separate RCTLinking from ReactInternal

Reviewed By: fkgozali

Differential Revision: D18314747

fbshipit-source-id: d9b5f536a6e93a0aca8721801a2ee5d446e0d4a6
This commit is contained in:
Ramanpreet Nara
2019-11-08 14:14:45 -08:00
committed by Facebook Github Bot
parent fb627dac6a
commit 525703de5b
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/CoreModules/BUCK
+1
View File
@@ -107,6 +107,7 @@ rn_apple_library(
reexport_all_header_dependencies = True,
visibility = ["PUBLIC"],
exported_deps = [
"fbsource//xplat/js:RCTLinkingApple",
"fbsource//xplat/js/react-native-github:ReactInternalApple",
"fbsource//xplat/js/react-native-github/Libraries/FBReactNativeSpec:FBReactNativeSpecApple",
],
ReactCommon/turbomodule/samples/BUCK
+1
View File
@@ -40,6 +40,7 @@ rn_xplat_cxx_library(
force_static = True,
ios_deps = [
"fbsource//xplat/FBBaseLite:FBBaseLite",
"fbsource//xplat/js:RCTLinking",
"fbsource//xplat/js/react-native-github:RCTCxxBridge",
"fbsource//xplat/js/react-native-github:RCTCxxModule",
"fbsource//xplat/js/react-native-github:ReactInternal",