From 525703de5b4e0eae16ac3d3acbf33eba9a7a4028 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Fri, 8 Nov 2019 14:08:11 -0800 Subject: [PATCH] Separate RCTLinking from ReactInternal Summary: None of the code inside `ReactInternal` depended on the `RCTLinkingManager` NativeModule. So I extracted `RCTLinking` into its own BUCK target. This will make it easier to make `RCTLinkingManager` TurboModule-compatible. ## Codemod Everywhere we required `ReactInternal`, we now also require `RCTLinking`: ``` > xbgr -f 'BUCK$' 'ReactInternal"' -l | xargs -I {} sed -i '' $'s|ReactInternal",|ReactInternal",\"fbsource//xplat/js:RCTLinking",|g' $HOME/{} > xbgr -f 'BUCK$' 'ReactInternalApple"' -l | xargs -I {} sed -i '' $'s|ReactInternalApple",|ReactInternalApple",\"fbsource//xplat/js:RCTLinkingApple",|g' $HOME/{} > arc f ``` Changelog: [Internal] - Separate RCTLinking from ReactInternal Reviewed By: fkgozali Differential Revision: D18314747 fbshipit-source-id: d9b5f536a6e93a0aca8721801a2ee5d446e0d4a6 --- React/CoreModules/BUCK | 1 + ReactCommon/turbomodule/samples/BUCK | 1 + 2 files changed, 2 insertions(+) diff --git a/React/CoreModules/BUCK b/React/CoreModules/BUCK index ee6872cc108..4eb322303ec 100644 --- a/React/CoreModules/BUCK +++ b/React/CoreModules/BUCK @@ -107,6 +107,7 @@ rn_apple_library( reexport_all_header_dependencies = True, visibility = ["PUBLIC"], exported_deps = [ + "fbsource//xplat/js:RCTLinkingApple", "fbsource//xplat/js/react-native-github:ReactInternalApple", "fbsource//xplat/js/react-native-github/Libraries/FBReactNativeSpec:FBReactNativeSpecApple", ], diff --git a/ReactCommon/turbomodule/samples/BUCK b/ReactCommon/turbomodule/samples/BUCK index 50478824e14..95d4469f746 100644 --- a/ReactCommon/turbomodule/samples/BUCK +++ b/ReactCommon/turbomodule/samples/BUCK @@ -40,6 +40,7 @@ rn_xplat_cxx_library( force_static = True, ios_deps = [ "fbsource//xplat/FBBaseLite:FBBaseLite", + "fbsource//xplat/js:RCTLinking", "fbsource//xplat/js/react-native-github:RCTCxxBridge", "fbsource//xplat/js/react-native-github:RCTCxxModule", "fbsource//xplat/js/react-native-github:ReactInternal",