mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Drop RCT_EXPORT_METHOD from RCTDevLoadingView TurboModule (#57680)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57680 Changelog: [Internal] `RCTDevLoadingView` is a TurboModule: it conforms to `NativeDevLoadingViewSpec` and implements `getTurboModule:` returning the codegen'd `...SpecJSI`. For TurboModules, the JS->ObjC dispatch is driven by codegen (the generated spec supplies the `selector` and argument kinds, invoked at runtime via `NSMethodSignature` / `NSInvocation`), not by the `RCT_EXPORT_METHOD` macro's `__rct_export__` metadata. The exported methods here are async-void with concrete parameter types (no generic `id` requiring `RCTConvert` coercion), so the macro is not functionally required. Convert them to plain ObjC method declarations; conformance to the codegen'd `NativeDevLoadingViewSpec` protocol keeps compiler-enforced signature parity. Signature-only refactor with no change to the JS-facing API. Sync methods, methods with `id` params, and `constantsToExport` are intentionally left untouched. Reviewed By: cortinico Differential Revision: D113579873 fbshipit-source-id: 78a43f3586b2b7433fad1ab13be50fae63197870
This commit is contained in:
1 parent
dc93ed0c4b
commit
50c2111384
1 file changed
+5
-4
@@ -244,16 +244,17 @@ RCT_EXPORT_MODULE()
|
||||
});
|
||||
}
|
||||
|
||||
RCT_EXPORT_METHOD(
|
||||
showMessage : (NSString *)message withColor : (NSNumber *__nonnull)color withBackgroundColor : (NSNumber *__nonnull)
|
||||
backgroundColor withDismissButton : (NSNumber *)dismissButton)
|
||||
- (void)showMessage:(NSString *)message
|
||||
withColor:(NSNumber *__nonnull)color
|
||||
withBackgroundColor:(NSNumber *__nonnull)backgroundColor
|
||||
withDismissButton:(NSNumber *)dismissButton
|
||||
{
|
||||
[self showMessage:message
|
||||
color:[RCTConvert UIColor:color]
|
||||
backgroundColor:[RCTConvert UIColor:backgroundColor]
|
||||
dismissButton:[dismissButton boolValue]];
|
||||
}
|
||||
RCT_EXPORT_METHOD(hide)
|
||||
- (void)hide
|
||||
{
|
||||
if (!RCTDevLoadingViewGetEnabled()) {
|
||||
return;
|
||||
|
||||
Reference in new issue
Block a user