mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Drop RCT_EXPORT_METHOD from RCTAppearance TurboModule (#57679)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57679 Changelog: [Internal] `RCTAppearance` is a TurboModule: it conforms to `NativeAppearanceSpec` and implements `getTurboModule:` returning the codegen'd `...SpecJSI`. For TurboModules, the JS->ObjC dispatch is driven by codegen (the generated spec supplies the `selector` and argument kinds, invoked at runtime via `NSMethodSignature` / `NSInvocation`), not by the `RCT_EXPORT_METHOD` macro's `__rct_export__` metadata. The exported methods here are async-void with concrete parameter types (no generic `id` requiring `RCTConvert` coercion), so the macro is not functionally required. Convert them to plain ObjC method declarations; conformance to the codegen'd `NativeAppearanceSpec` protocol keeps compiler-enforced signature parity. Signature-only refactor with no change to the JS-facing API. Sync methods, methods with `id` params, and `constantsToExport` are intentionally left untouched. Reviewed By: cortinico Differential Revision: D113579869 fbshipit-source-id: 3706395afba81397c87e33cc4b058dbb78222bcd
This commit is contained in:
1 parent
c8c4d6eb5b
commit
dc93ed0c4b
1 file changed
+1
-1
@@ -109,7 +109,7 @@ RCT_EXPORT_MODULE(Appearance)
|
||||
return std::make_shared<NativeAppearanceSpecJSI>(params);
|
||||
}
|
||||
|
||||
RCT_EXPORT_METHOD(setColorScheme : (NSString *)style)
|
||||
- (void)setColorScheme:(NSString *)style
|
||||
{
|
||||
UIUserInterfaceStyle userInterfaceStyle = [RCTConvert UIUserInterfaceStyle:style];
|
||||
NSMutableArray<UIWindow *> *windows = [NSMutableArray new];
|
||||
|
||||
Reference in new issue
Block a user