mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Decouple network inspection from enableBridgelessArchitecture (#57530)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57530 Replaces D111696522. Since bridgeless is stable/default-true, this is behavior-preserving. This feature also never strictly depended upon Bridgeless. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D111703862 fbshipit-source-id: aaf94b4abd41b009950242b035e71d659b895bd2
This commit is contained in:
1 parent
798b550dd4
commit
4970200a19
6 files changed
+7
-15
No files matched your search
+2
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c9e8eeefc709e1246577d67155300906>>
|
||||
* @generated SignedSource<<854bb2a573f2c69d495aa1721f903ab0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -379,7 +379,7 @@ public object ReactNativeFeatureFlags {
|
||||
public fun fuseboxFrameRecordingEnabled(): Boolean = accessor.fuseboxFrameRecordingEnabled()
|
||||
|
||||
/**
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun fuseboxNetworkInspectionEnabled(): Boolean = accessor.fuseboxNetworkInspectionEnabled()
|
||||
|
||||
@@ -82,7 +82,6 @@ const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
|
||||
false,
|
||||
#endif
|
||||
.networkInspectionEnabled =
|
||||
ReactNativeFeatureFlags::enableBridgelessArchitecture() &&
|
||||
ReactNativeFeatureFlags::fuseboxNetworkInspectionEnabled(),
|
||||
.perfIssuesEnabled = ReactNativeFeatureFlags::perfIssuesEnabled(),
|
||||
};
|
||||
|
||||
-7
@@ -46,13 +46,6 @@ class ReactNativeFeatureFlagsOverrides
|
||||
ReactNativeFeatureFlagsDefaults::fuseboxNetworkInspectionEnabled());
|
||||
}
|
||||
|
||||
bool enableBridgelessArchitecture() override {
|
||||
// NOTE: Network support is gated by (enableBridgelessArchitecture &&
|
||||
// fuseboxNetworkInspectionEnabled).
|
||||
return overrides_.networkInspectionEnabled.value_or(
|
||||
ReactNativeFeatureFlagsDefaults::enableBridgelessArchitecture());
|
||||
}
|
||||
|
||||
bool enableNetworkEventReporting() override {
|
||||
return overrides_.enableNetworkEventReporting.value_or(
|
||||
ReactNativeFeatureFlagsDefaults::enableNetworkEventReporting());
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5c7e2061344bf998e5fc6b621af2ff45>>
|
||||
* @generated SignedSource<<4276ae19d55acb679c9e635122e813b3>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -330,7 +330,7 @@ class ReactNativeFeatureFlags {
|
||||
RN_EXPORT static bool fuseboxFrameRecordingEnabled();
|
||||
|
||||
/**
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
|
||||
*/
|
||||
RN_EXPORT static bool fuseboxNetworkInspectionEnabled();
|
||||
|
||||
|
||||
@@ -673,7 +673,7 @@ const definitions: FeatureFlagDefinitions = {
|
||||
metadata: {
|
||||
dateAdded: '2024-01-31',
|
||||
description:
|
||||
'Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.',
|
||||
'Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.',
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'experimentation',
|
||||
},
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<36a98575851fdf73cb45a0d34c3a8755>>
|
||||
* @generated SignedSource<<71e307d568421d49e3943f58c4fcb163>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -444,7 +444,7 @@ export const fuseboxEnabledRelease: Getter<boolean> = createNativeFlagGetter('fu
|
||||
*/
|
||||
export const fuseboxFrameRecordingEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxFrameRecordingEnabled', false);
|
||||
/**
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
|
||||
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
|
||||
*/
|
||||
export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxNetworkInspectionEnabled', true);
|
||||
/**
|
||||
|
||||
Reference in new issue
Block a user