From 4970200a192197687a6b7e94abde88374ced2d99 Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Mon, 13 Jul 2026 09:02:22 -0700 Subject: [PATCH] Decouple network inspection from enableBridgelessArchitecture (#57530) Summary: Pull Request resolved: https://github.com/react/react-native/pull/57530 Replaces D111696522. Since bridgeless is stable/default-true, this is behavior-preserving. This feature also never strictly depended upon Bridgeless. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D111703862 fbshipit-source-id: aaf94b4abd41b009950242b035e71d659b895bd2 --- .../react/internal/featureflags/ReactNativeFeatureFlags.kt | 4 ++-- .../ReactCommon/jsinspector-modern/InspectorFlags.cpp | 1 - .../tests/utils/InspectorFlagOverridesGuard.cpp | 7 ------- .../react/featureflags/ReactNativeFeatureFlags.h | 4 ++-- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 2 +- .../src/private/featureflags/ReactNativeFeatureFlags.js | 4 ++-- 6 files changed, 7 insertions(+), 15 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt index 596ec7484e8..04d0b80b3c6 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<854bb2a573f2c69d495aa1721f903ab0>> */ /** @@ -379,7 +379,7 @@ public object ReactNativeFeatureFlags { public fun fuseboxFrameRecordingEnabled(): Boolean = accessor.fuseboxFrameRecordingEnabled() /** - * Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes. + * Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes. */ @JvmStatic public fun fuseboxNetworkInspectionEnabled(): Boolean = accessor.fuseboxNetworkInspectionEnabled() diff --git a/packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp b/packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp index 6c64e2f1393..59cae70d8b7 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp @@ -82,7 +82,6 @@ const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged() false, #endif .networkInspectionEnabled = - ReactNativeFeatureFlags::enableBridgelessArchitecture() && ReactNativeFeatureFlags::fuseboxNetworkInspectionEnabled(), .perfIssuesEnabled = ReactNativeFeatureFlags::perfIssuesEnabled(), }; diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tests/utils/InspectorFlagOverridesGuard.cpp b/packages/react-native/ReactCommon/jsinspector-modern/tests/utils/InspectorFlagOverridesGuard.cpp index 17a83c99413..6dcdcd69699 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tests/utils/InspectorFlagOverridesGuard.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/tests/utils/InspectorFlagOverridesGuard.cpp @@ -46,13 +46,6 @@ class ReactNativeFeatureFlagsOverrides ReactNativeFeatureFlagsDefaults::fuseboxNetworkInspectionEnabled()); } - bool enableBridgelessArchitecture() override { - // NOTE: Network support is gated by (enableBridgelessArchitecture && - // fuseboxNetworkInspectionEnabled). - return overrides_.networkInspectionEnabled.value_or( - ReactNativeFeatureFlagsDefaults::enableBridgelessArchitecture()); - } - bool enableNetworkEventReporting() override { return overrides_.enableNetworkEventReporting.value_or( ReactNativeFeatureFlagsDefaults::enableNetworkEventReporting()); diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h index ec0b8ce66b8..a2ca86c275a 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<5c7e2061344bf998e5fc6b621af2ff45>> + * @generated SignedSource<<4276ae19d55acb679c9e635122e813b3>> */ /** @@ -330,7 +330,7 @@ class ReactNativeFeatureFlags { RN_EXPORT static bool fuseboxFrameRecordingEnabled(); /** - * Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes. + * Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes. */ RN_EXPORT static bool fuseboxNetworkInspectionEnabled(); diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index 7fa01e39e35..aaef339af77 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -673,7 +673,7 @@ const definitions: FeatureFlagDefinitions = { metadata: { dateAdded: '2024-01-31', description: - 'Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.', + 'Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.', expectedReleaseValue: true, purpose: 'experimentation', }, diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index e5eea64c6e3..a9c69041434 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<36a98575851fdf73cb45a0d34c3a8755>> + * @generated SignedSource<<71e307d568421d49e3943f58c4fcb163>> * @flow strict * @noformat */ @@ -444,7 +444,7 @@ export const fuseboxEnabledRelease: Getter = createNativeFlagGetter('fu */ export const fuseboxFrameRecordingEnabled: Getter = createNativeFlagGetter('fuseboxFrameRecordingEnabled', false); /** - * Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes. + * Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes. */ export const fuseboxNetworkInspectionEnabled: Getter = createNativeFlagGetter('fuseboxNetworkInspectionEnabled', true); /**