Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing crash in ComponentDescriptorRegistry

Browse Source 
Summary: Until ComponentDescriptorProviderRequest is not fully implemented we need to disable the assert because it enforces constraints that we don't satisfy yet.

Reviewed By: JoshuaGross

Differential Revision: D17677856

fbshipit-source-id: bdf96a04a16981f1c639f646f254e8f3dd799419
This commit is contained in:
Valentin Shergin
2019-09-30 17:30:18 -07:00
committed by Facebook Github Bot
parent 101125f891
commit 3e23a21025
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp
+9 -1
View File
@@ -135,7 +135,15 @@ ComponentDescriptor const &ComponentDescriptorRegistry::at(
mutex_.lock_shared();
it = _registryByName.find(unifiedComponentName);
assert(it != _registryByName.end());
/*
* TODO: T54849676
* Uncomment the `assert` after the following block that checks
* `_fallbackComponentDescriptor` is no longer needed. The assert assumes
* that `componentDescriptorProviderRequest` is always not null and register
* some component on every single request.
*/
// assert(it != _registryByName.end());
}
if (it == _registryByName.end()) {