From 3e23a21025099e0f0ea464453772d5bbb3e19793 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 30 Sep 2019 17:28:12 -0700 Subject: [PATCH] Fixing crash in ComponentDescriptorRegistry Summary: Until ComponentDescriptorProviderRequest is not fully implemented we need to disable the assert because it enforces constraints that we don't satisfy yet. Reviewed By: JoshuaGross Differential Revision: D17677856 fbshipit-source-id: bdf96a04a16981f1c639f646f254e8f3dd799419 --- .../fabric/uimanager/ComponentDescriptorRegistry.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp b/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp index b30d3fee014..7325e225a47 100644 --- a/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp +++ b/ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp @@ -135,7 +135,15 @@ ComponentDescriptor const &ComponentDescriptorRegistry::at( mutex_.lock_shared(); it = _registryByName.find(unifiedComponentName); - assert(it != _registryByName.end()); + + /* + * TODO: T54849676 + * Uncomment the `assert` after the following block that checks + * `_fallbackComponentDescriptor` is no longer needed. The assert assumes + * that `componentDescriptorProviderRequest` is always not null and register + * some component on every single request. + */ + // assert(it != _registryByName.end()); } if (it == _registryByName.end()) {