Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete empty didRegisterUserNotificationSettings (#41013)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41013

## Changelog:

[iOS][Breaking] Deleted the no-op didRegisterUserNotificationSettings: callback in RCTPushNotificationManager

Reviewed By: philIip

Differential Revision: D50283620

fbshipit-source-id: 1582367c51c26e5b739cd9284d3b15bfa13274da
This commit is contained in:
Ingrid Wang
2023-10-16 17:01:16 -07:00
committed by Facebook GitHub Bot
parent bb9cc0ccec
commit 3bea8e1bd4
3 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h
-1
View File
@@ -14,7 +14,6 @@ extern NSString *const RCTRemoteNotificationReceived;
typedef void (^RCTRemoteNotificationCallback)(UIBackgroundFetchResult result);
#if !TARGET_OS_UIKITFORMAC
+ (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;
+ (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
+ (void)didReceiveRemoteNotification:(NSDictionary *)notification;
+ (void)didReceiveRemoteNotification:(NSDictionary *)notification
packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm
-4
View File
@@ -176,10 +176,6 @@ RCT_EXPORT_MODULE()
];
}
+ (void)didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings
{
}
+ (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
NSMutableString *hexString = [NSMutableString string];
packages/rn-tester/RNTester/AppDelegate.mm
-7
View File
@@ -88,13 +88,6 @@ NSString *kBundlePath = @"js/RNTesterApp.ios";
#if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
// Required to register for notifications
- (void)application:(__unused UIApplication *)application
didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
{
[RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
}
// Required for the remoteNotificationsRegistered event.
- (void)application:(__unused UIApplication *)application
didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken