From 3bea8e1bd41cf019bcd01acaef8256e2b3dbd742 Mon Sep 17 00:00:00 2001 From: Ingrid Wang Date: Mon, 16 Oct 2023 17:01:16 -0700 Subject: [PATCH] Delete empty didRegisterUserNotificationSettings (#41013) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41013 ## Changelog: [iOS][Breaking] Deleted the no-op didRegisterUserNotificationSettings: callback in RCTPushNotificationManager Reviewed By: philIip Differential Revision: D50283620 fbshipit-source-id: 1582367c51c26e5b739cd9284d3b15bfa13274da --- .../PushNotificationIOS/RCTPushNotificationManager.h | 1 - .../PushNotificationIOS/RCTPushNotificationManager.mm | 4 ---- packages/rn-tester/RNTester/AppDelegate.mm | 7 ------- 3 files changed, 12 deletions(-) diff --git a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h index 778db415b58..e49f6ed9d54 100644 --- a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h +++ b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h @@ -14,7 +14,6 @@ extern NSString *const RCTRemoteNotificationReceived; typedef void (^RCTRemoteNotificationCallback)(UIBackgroundFetchResult result); #if !TARGET_OS_UIKITFORMAC -+ (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings; + (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken; + (void)didReceiveRemoteNotification:(NSDictionary *)notification; + (void)didReceiveRemoteNotification:(NSDictionary *)notification diff --git a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm index 469e05af9a2..fce0ad95d79 100644 --- a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm +++ b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm @@ -176,10 +176,6 @@ RCT_EXPORT_MODULE() ]; } -+ (void)didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings -{ -} - + (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken { NSMutableString *hexString = [NSMutableString string]; diff --git a/packages/rn-tester/RNTester/AppDelegate.mm b/packages/rn-tester/RNTester/AppDelegate.mm index 1bf36697556..40582e7296b 100644 --- a/packages/rn-tester/RNTester/AppDelegate.mm +++ b/packages/rn-tester/RNTester/AppDelegate.mm @@ -88,13 +88,6 @@ NSString *kBundlePath = @"js/RNTesterApp.ios"; #if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC -// Required to register for notifications -- (void)application:(__unused UIApplication *)application - didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings -{ - [RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings]; -} - // Required for the remoteNotificationsRegistered event. - (void)application:(__unused UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken