Create a new Timers class to reuse old RCTTiming Native Module [2/N]

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Summary:
Similar to Android Venice impl, I plan to reuse old Timing native module because it's quite complex, and there's not much to gain from re-writing it. When we delete bridge access from it, we can remove any cruft, but IMO it's quite lean already.

The name of this class is a little confusing IMO, I originally had it because it was similar to `Timers.java` but then Emily renamed :p Here's the architecture drawn out:

{F209114665}

If anyone has a better name I'm all ears.

Reviewed By: RSNara

Differential Revision: D17376028

fbshipit-source-id: 066ae0b379cd00538021a1327a4dd63d5a828608

This commit is contained in:

Peter Argany

2019-09-20 18:28:38 -07:00

committed by

Facebook Github Bot

parent 77c9c95840

commit 33e65c6fd4

1 changed files with 1 additions and 0 deletions

									
										React/Modules/RCTTiming.h
									
		+1
		
												View File
												
				@@ -26,6 +26,7 @@

				           duration:(NSTimeInterval)jsDuration

				   jsSchedulingTime:(NSDate *)jsSchedulingTime

				            repeats:(BOOL)repeats;

				- (void)deleteTimer:(nonnull NSNumber *)timerID;

				@end