From 33e65c6fd43234ec68a1aeda100736ef39be8a35 Mon Sep 17 00:00:00 2001 From: Peter Argany Date: Fri, 20 Sep 2019 18:25:29 -0700 Subject: [PATCH] Create a new Timers class to reuse old RCTTiming Native Module [2/N] Summary: Similar to Android Venice impl, I plan to reuse old Timing native module because it's quite complex, and there's not much to gain from re-writing it. When we delete bridge access from it, we can remove any cruft, but IMO it's quite lean already. The name of this class is a little confusing IMO, I originally had it because it was similar to `Timers.java` but then Emily renamed :p Here's the architecture drawn out: {F209114665} If anyone has a better name I'm all ears. Reviewed By: RSNara Differential Revision: D17376028 fbshipit-source-id: 066ae0b379cd00538021a1327a4dd63d5a828608 --- React/Modules/RCTTiming.h | 1 + 1 file changed, 1 insertion(+) diff --git a/React/Modules/RCTTiming.h b/React/Modules/RCTTiming.h index 72b760d0e08..1c8ad30bce6 100644 --- a/React/Modules/RCTTiming.h +++ b/React/Modules/RCTTiming.h @@ -26,6 +26,7 @@ duration:(NSTimeInterval)jsDuration jsSchedulingTime:(NSDate *)jsSchedulingTime repeats:(BOOL)repeats; +- (void)deleteTimer:(nonnull NSNumber *)timerID; @end