Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant return value from ReactScrollViewHelper (#38752)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38752

changelog: [internal]

The return value is not used, let's remove it.

Reviewed By: ryancat

Differential Revision: D47916485

fbshipit-source-id: 1275b6146f8d3abe624991ed8e76abb5ac99984b
This commit is contained in:
Samuel Susla
2023-09-11 14:34:23 -07:00
committed by Facebook GitHub Bot
parent db4a253c1e
commit 2a48c955d9
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java
+6 -6
View File
@@ -394,15 +394,15 @@ public class ReactScrollViewHelper {
}
public static <T extends ViewGroup & HasStateWrapper & HasScrollState & HasFlingAnimator>
boolean updateFabricScrollState(final T scrollView) {
return updateFabricScrollState(scrollView, scrollView.getScrollX(), scrollView.getScrollY());
void updateFabricScrollState(final T scrollView) {
updateFabricScrollState(scrollView, scrollView.getScrollX(), scrollView.getScrollY());
}
/**
* Called on any stabilized onScroll change to propagate content offset value to a Shadow Node.
*/
public static <T extends ViewGroup & HasStateWrapper & HasScrollState & HasFlingAnimator>
boolean updateFabricScrollState(final T scrollView, final int scrollX, final int scrollY) {
void updateFabricScrollState(final T scrollView, final int scrollX, final int scrollY) {
if (DEBUG_MODE) {
FLog.i(
TAG,
@@ -413,18 +413,18 @@ public class ReactScrollViewHelper {
}
if (ViewUtil.getUIManagerType(scrollView.getId()) == UIManagerType.DEFAULT) {
return false;
return;
}
final ReactScrollViewScrollState scrollState = scrollView.getReactScrollViewScrollState();
// Dedupe events to reduce JNI traffic
if (scrollState.getLastStateUpdateScroll().equals(scrollX, scrollY)) {
return false;
return;
}
scrollState.setLastStateUpdateScroll(scrollX, scrollY);
forceUpdateState(scrollView);
return true;
return;
}
public static <T extends ViewGroup & HasScrollState & HasStateWrapper & HasFlingAnimator>