From 2a48c955d97431f0bb7d78a0b7e04d5ae2bcd3c7 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 11 Sep 2023 14:34:23 -0700 Subject: [PATCH] Remove redundant return value from ReactScrollViewHelper (#38752) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38752 changelog: [internal] The return value is not used, let's remove it. Reviewed By: ryancat Differential Revision: D47916485 fbshipit-source-id: 1275b6146f8d3abe624991ed8e76abb5ac99984b --- .../react/views/scroll/ReactScrollViewHelper.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java index a687fdff88b..49fe5f52561 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java @@ -394,15 +394,15 @@ public class ReactScrollViewHelper { } public static - boolean updateFabricScrollState(final T scrollView) { - return updateFabricScrollState(scrollView, scrollView.getScrollX(), scrollView.getScrollY()); + void updateFabricScrollState(final T scrollView) { + updateFabricScrollState(scrollView, scrollView.getScrollX(), scrollView.getScrollY()); } /** * Called on any stabilized onScroll change to propagate content offset value to a Shadow Node. */ public static - boolean updateFabricScrollState(final T scrollView, final int scrollX, final int scrollY) { + void updateFabricScrollState(final T scrollView, final int scrollX, final int scrollY) { if (DEBUG_MODE) { FLog.i( TAG, @@ -413,18 +413,18 @@ public class ReactScrollViewHelper { } if (ViewUtil.getUIManagerType(scrollView.getId()) == UIManagerType.DEFAULT) { - return false; + return; } final ReactScrollViewScrollState scrollState = scrollView.getReactScrollViewScrollState(); // Dedupe events to reduce JNI traffic if (scrollState.getLastStateUpdateScroll().equals(scrollX, scrollY)) { - return false; + return; } scrollState.setLastStateUpdateScroll(scrollX, scrollY); forceUpdateState(scrollView); - return true; + return; } public static