Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rendering of textInput using lineHeight in android API level <28 (#42673)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42673

Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight.
ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method

changelog: [Internal] internal

Differential Revision: D53105649

fbshipit-source-id: f2d81cfea10de84bd47efbfeac1e21837fd49a11
This commit is contained in:
David Vacca
2024-01-25 19:20:17 -08:00
committed by Facebook GitHub Bot
parent 62e5980954
commit 142f13db63
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java
+3 -1
View File
@@ -273,7 +273,9 @@ public class ReactEditText extends AppCompatEditText {
@Override
public void setLineHeight(int lineHeight) {
mTextAttributes.setLineHeight(lineHeight);
super.setLineHeight(lineHeight);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
super.setLineHeight(lineHeight);
}
}
@Override