From 142f13db63109ec73c3fde916d1ee2f4096e08a4 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 25 Jan 2024 19:20:17 -0800 Subject: [PATCH] Fix rendering of textInput using lineHeight in android API level <28 (#42673) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42673 Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight. ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method changelog: [Internal] internal Differential Revision: D53105649 fbshipit-source-id: f2d81cfea10de84bd47efbfeac1e21837fd49a11 --- .../com/facebook/react/views/textinput/ReactEditText.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java index c4d42eb13f0..39e53d255fa 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java @@ -273,7 +273,9 @@ public class ReactEditText extends AppCompatEditText { @Override public void setLineHeight(int lineHeight) { mTextAttributes.setLineHeight(lineHeight); - super.setLineHeight(lineHeight); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) { + super.setLineHeight(lineHeight); + } } @Override