The button-state cases reimplemented the card's `btnDisabled` expression
inside the test file, so they asserted against a copy of the logic. The
guard could be dropped from the component and every test naming the
reported bug would still pass.
Fold the derivation into `usersLimitState()`, render the card from it,
and drive the tests through it. Verified by mutation: dropping the error
guard, dropping the limited-mode guard, and ignoring mode in the
changed-check now fail 1, 1 and 2 cases; against the old tests all three
passed clean.
The user-limit policy reserves `total: 0` for "no limit", but the card
treated 0 as a value you could type. On a project with no limit,
selecting Limited and entering 0 left `policy.total === newLimit`, so
Update stayed disabled with nothing explaining why.
The same check had three more holes: entering 0 on an already-limited
project saved `total: 0` and silently turned the limit off while the UI
still read "Limited 0"; clearing the field bound `undefined` and made
the SDK throw `Missing required parameter: "total"`; and with no `min`
on the input a negative value reached the API as a 400.
Move the range and changed-vs-saved checks into usersLimit.ts, put
min/max/step on the input, and surface a rejected value as an inline
error instead of a dead button. 0 can no longer be submitted as a
limit, so the card cannot drift out of sync with the saved policy.
Also drop `maxUsersInputField` and its focus effect: nothing ever bound
it, so it was always null and never ran. Wiring it up would have
auto-focused and scrolled to the card on every page load.
* fix(storage): correct allowed file extensions input copy
The bucket settings Allowed file extensions field reused Labels copy
(id, label, and placeholder). Use extension-specific wording and clear
the placeholder once tags are present so it does not sit beside chips.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* chore: retrigger CI after flaky onboarding e2e
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* chore: retrigger flaky onboarding e2e (2)
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* chore: retrigger flaky onboarding e2e (3)
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix(auth): navigate after cloud signup so onboarding e2e can proceed
Cloud register only called goto when a pricing type was present, so CI
stayed on /register until waitForURL timed out.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(e2e): drop verify-email skip after register
Address review feedback: keep waiting for onboarding create-project
and remove the temporary CI nudge comment on the extensions field.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
D5's answer to the customer in the support thread was explicit: Pro
doesn't include SOC-2, "you need the custom plan" — not Scale. The
previous gate OR'd in `planHasGroup(Scale)`, which was inferred from
planComparisonBox's marketing copy rather than any real entitlement,
and would have wrongly let a self-service Scale org through.
Checked plans.php in the cloud repo: every self-service plan (Pro,
Scale) sets `selfService: true`, and every negotiated Custom/Enterprise
contract plan sets it `false` — `supportedAddons` doesn't distinguish
them for anything SOC-2-shaped (it only carries the paid, self-service
BAA/premiumGeoDB addons). `selfService` is already a real field the
API returns per plan today, so gating on `selfService === false` alone
needs no backend change and matches support's stated policy exactly,
instead of guessing at a group boundary.
Also swapped the ineligible-state CTA from the self-service change-plan
wizard to the existing Enterprise contact-sales link, since there's no
self-service upgrade path onto a plan that actually unlocks this.
The SOC-2 card rendered for every cloud organization owner, so Free and
Pro users could fill in the whole request form and only learn it was
unavailable from a generic "please try again later" error. BAA, the card
directly above it, has always been gated on `supportedAddons.baa`.
No SOC-2 entitlement exists on the plan model, so infer it: the Scale
group is the lowest one that advertises SOC-2 (the Enterprise column on
the pricing page), and contract plans sit above it. Ineligible
organizations now get a short explanation and an upgrade CTA instead of
a form that cannot succeed, and the modal is no longer mounted for them.
Also send the request as multipart form data, the shape the support
wizard uses. SOC-2 was the last caller posting JSON to growth's
/support: the wizard moved to FormData in e446f7ff8 and the BAA request
modal, the other JSON caller, went away in bf2166bd3, so if that path
has rotted the request was failing on every plan including Enterprise.
The billing plan now rides along in metaFields so support can see the
tier on the ticket.
This repo has no existing Svelte component test pattern, so covering
the fix meant inventing one from scratch: jsdom localStorage/
ResizeObserver shims plus a harness component, none of which serves
anything else here. Not warranted for a bug fix. The fix itself
(selection reset on URL change + keyed row loops) stands on its own.
Selection state in MultiSelectionTable stuck around across pagination
and search, keyed only on row id. Selecting rows, then paginating to a
different page and hitting "select all" would carry the old ids into
the new batch delete, silently deleting rows the user never saw
selected. Reported from Storage and Databases in production.
Reset selection whenever the URL changes, and key the previously
unkeyed row each-blocks (files, users, memberships, platforms,
backups) so Svelte doesn't reuse row elements across renders.
* fix(git): portal branch selector to body to stop modal wiggle
Portaling the fixed-position dropdown into <dialog> made it resolve
against the dialog containing block, so opening Production branch
shifted modal contents (#2790). Append to document.body instead and
stopPropagation so outside-click dismiss still works.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix(git): portal branch menu into dialog with dialog-relative coords
Body portals sit under showModal() top layer, so the dropdown was
unreachable. Keep portaling into the open dialog for stacking, but
convert getBoundingClientRect() to dialog-local coordinates — fixed
positioning inside the dialog is relative to that box, and viewport
coords were what shifted the modal (#2790).
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix(git): detect owning dialog via closest() for branch portal
Svelte slot projection means BranchSelector never sees pink Modal's
dialog-group context, so the dialog portal path never ran. Use
containerEl.closest('dialog') instead so create-deployment menus
still join the showModal() top layer with dialog-local coordinates.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Back only cleared the selected user; it left the membership request in
flight and did not advance the request counter, so nothing invalidated
it. On rejection the guard still matched, and the error landed on the
user step — reporting "Could not load users." over a user list that had
loaded fine, with a Retry that re-ran the wrong request.
Back now invalidates the in-flight request and clears the error and
spinner it owns. The rejection path also checks the selected user, so it
matches the success path rather than relying on the counter alone.
A rejected request left the list undefined, which reads identically to a
successful empty response, so the picker stated that the user belongs to
no teams — and offered nothing to click, leaving Back and re-selecting
the user as the only way to try again.
The failure is now held separately from the list and rendered as its own
state with a Retry, in both steps. In the user step it is checked ahead
of the search branch, so a search that fails reports the failure rather
than claiming the term matched nothing.
Stepping back and choosing a second user, or typing another search term,
leaves the earlier request in flight. Whichever resolves last was writing
to the shared list, so one user's memberships could be listed under
another user's name — and a row selected there would have granted the
membership actually belonging to the first user.
Requests now carry a sequence number and only the newest may write, with
the membership step additionally confirming the selection has not moved
on beneath it.
A rejected request also skipped the assignment that cleared the spinner,
leaving the picker loading forever with nothing said. Both requests now
settle in a finally and surface the failure.
The member role has been in the API and the docs since 1.0, but neither
console ever offered it — the only way to set one was to know the syntax
and type it into the custom permission box.
It keys on a membership ID, which nothing in the console surfaces, so
the picker resolves it in two steps: find the user, then choose which of
their team memberships to grant. It has to run in that direction —
teams.listMemberships indexes only the membership ID and the user ID for
search, so picking a team first would leave the member step with a
search box that matches nothing. users.list indexes name, email and
phone, so the first step behaves like the existing user picker.
parsePermission only recognised user and team, so a member role fell
through to the invalid branch: it rendered as a raw truncated string in
the styling reserved for a deleted entity, and its hover card showed the
missing-entity avatar — presenting a perfectly valid grant as broken.
It also called onNotFound. Nothing passes that callback today, but
d36135f5b wired it to auto-remove stale roles before row.svelte moved to
runes turned the event into a prop and left the consumer behind. If that
wiring is restored, member roles would be silently deleted from any
resource a user merely opened.
A membership can only be read through its team or its user, and the role
string carries neither, so the ID stands in for a name. That is still an
improvement on the raw role: the badge now reads Member and the hover
card offers the membership ID to copy.
Check the plan site limit before calling vcs.createRepository in the
template wizard, and disable Create site on the list page when limited,
so users are not left with empty GitHub repositories after a failed deploy.
Fixes#2175
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Point the generic docs links in both MCP cards at the MCP servers page
instead of the docs root.
Refresh the one-click install list:
- Cursor and VS Code now use their protocol/install handlers
- Claude Desktop becomes Claude Code, linking to its agent docs page
- Windsurf becomes Codex, linking to its agent docs page
- Fix "VS code" casing
Claude Code and Codex have no URL-scheme install, so they link to docs.
Soften the "One-click install" heading to "Quick install" to match.
Replace the Windsurf icon with an OpenAI mark for Codex, reusing the
same asset the docs site ships.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: refresh $updatedAt after inline row edits
Inline spreadsheet edits called updateRow but kept the pre-write row in
local state, so $updatedAt never changed until a full reload. Apply the
API response system fields before updating the grid (console#2873).
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* chore: retrigger CI
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* chore: nudge CI for stuck Tests queue
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix: normalize smart quotes in function execution body
Safari substitutes curly quotes while typing, which makes JSON bodies
invalid (console#2872). Normalize typographic quotes on submit and
disable spellcheck on the body textarea.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix: only repair smart quotes when they invalidate JSON
Address Greptile P1: unconditional normalization could rewrite intentional
typographic quotes in valid JSON string values or plain-text bodies.
Only normalize when the original body fails JSON.parse and the repaired
body succeeds.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
* fix: repair only curly double quotes in JSON bodies
Narrow Greptile follow-up: JSON delimiters are double quotes, so leave
apostrophes/single smart quotes untouched. Still only rewrite when the
original body is invalid JSON and the repaired body parses.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Datetime inputs are displayed as timezone-less local ISO strings. Without
converting back to UTC on submit, unchanged datetime fields drift by the
browser offset on every update (console#2870). Mirror the filters path and
canonicalize datetime scalars/arrays in buildPayload.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
`executions` is the umbrella metric covering both functions and sites,
but the table it feeds is headed "Function" and links each row to
/functions/function-{resourceId}. A project with a trafficked site would
get rows showing a raw site ID, unresolvable by functions.list, linking
to a function that does not exist. `functions.executions` is the metric
that matches the table.
Fold the call into the load function's existing Promise.all so it no
longer serialises behind the invoice and usage requests, and report a
failure through trackError instead of swallowing it — a 403 or a
malformed response was previously indistinguishable from a project with
no executions.
Drop the duplicate database-type read in the collection layout, which
recomputed locally what the component already derives.
Matches the project settings cards, which disable their controls on
!$canWriteProjects rather than letting a read-only member submit a
request the API rejects.
Also fills in labels, installationScopes, and installationRedirectUrl on
the App literal built from a CIMD document. Those three became required
on Models.App in SDK 16 and a CIMD document carries none of them, so
they take the same empty defaults as the other fields the document
does not provide.
Lets a project choose which factors can complete an MFA challenge,
including the new custom factor, where Appwrite generates and verifies
the code and the app delivers it over a channel of its own.
The card stays hidden when listPolicies() omits mfa-factors, so a
self-hosted server older than 1.9.6 does not render a control whose
PATCH would 404.
The 1.9.6 console spec adds the mfa-factors project policy, which the
pinned 15.3.0 build predates.
The major bump also removes the Health service (registered in the SDK
store but never called), renames Models.CloudLocale to Models.Locale,
moves createTextEmbeddings from VectorsDB to a new Embeddings service,
drops UsageProject.executionsBreakdown in favour of the dimensional
usage API, and splits the composite `databaseId:collectionId` migration
resourceId into resourceId plus parentResourceId.
Models.Database.type is now the SDK's DatabaseType enum, which also
covers the dedicated backings (mysql, postgresql, mongodb) this console
has no UI for. The local union is extracted from the SDK enum so a
renamed or dropped value breaks the switches instead of drifting
silently, and toDatabaseType() narrows at the boundary — matching the
entity dispatchers, which already throw on an unknown type.
The avatar used object-fit: cover, which crops a wide wordmark into an
unreadable fragment. Switching to contain fixes that for every client, so
the appwrite-cli special case and its resolver helper are unnecessary.
Hardcoding the CLI's client ID in the console was also the wrong layer:
logoUri is server-owned app-registry data, so a square mark belongs in the
registration upstream. Worse, app IDs are user-supplied, so anyone able to
create an OAuth app on a self-hosted instance could claim `appwrite-cli`
and render official Appwrite branding on a consent screen.
The helper's trim/?? '' normalization was dead too: the {#if} already
covered empty and undefined, and cimdDocumentToApp gates logoUri through
HTTP_URL before it ever reaches the template.
Fold the rule into .avatar rather than a separate img.avatar block. Every
other .avatar is a flex-centered div, so object-fit is inert there and the
padding stays harmless.
After invalidate, the store holds the new phoneVerification value.
Match the email path so the toast reports verified/unverified correctly.
Fixes#1392
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
The cloud values moved out of appwrite-labs/cloud-applications into the
consolidated appwrite-labs/application-configuration repository, which is
laid out as <project>/<env>/<app> instead of <env>/<app>.
The values path was hardcoded; it now builds from PROJECT/ENVIRONMENT/
APPLICATION like the other deploy workflows. The tag still lands on the
`cloud-console` alias inside the cloud release, and production still
opens a reviewed PR rather than pushing to main.
The first-party appwrite-cli client registers a wide wordmark as logoUri.
Consent/outcome avatars use a square crop, so object-fit:cover left an
unreadable fragment that looked like a missing logo (#3159). Prefer the
square mark for that client and contain-fit other logos in the avatar.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
The three create-site pages conflicted only in their import blocks: main
dropped the FrameworkAdapterWithStartCommand import along with the adapter
start-command reads, while this branch added validateVariables next to it.
Kept both sides' intent — the type is gone from $lib/stores/sites and no
longer referenced, so only the validateVariables import remains.
/console/card and /console/card/<uid> served the 2023 Cloud public beta
shareable card. The API no longer serves /cards/cloud, so both loaders
already bounced to / — the pages were unreachable.
getCampaignImageUrl was the only live export under the route and has
nothing to do with the card, so it moves to $lib/helpers/campaign.ts
next to its one consumer, the unauthenticated layout. getCardImgUrls
went with the route; the [uid] loader kept its own copy. windowFocus.ts
had no consumer besides Card.svelte, and the console layout's /card
path check guarded a route that never rendered under that group.
bun audit fails on GHSA-2v37-7h3g-55p8: the lockfile pinned nanoid 3.3.17
under postcss and @ai-sdk/provider-utils, and neither `bun update nanoid`
nor updating those parents re-resolved it. Bun ignores npm's nested
override syntax, so the override has to be flat.
That takes the direct dependency to the 3.x line as well. The only use is
nanoid/non-secure, which 3.x provides, and the declared range now matches
what installs rather than claiming a 5.x that the override replaces.
The effect is skipped whenever the URL supplied any command, so a deploy
link carrying ?start= kept that entrypoint through a framework switch.
Resetting inside the effect could not fix it either: the effect also runs
on load, where the URL value has to survive.
Move the reset onto the select, so only a user changing framework clears
it and the link keeps working as written.
The settings form already resets it; the create flows kept the previous
framework's entrypoint in state and submitted it, and kept sending it
after a switch to a framework that only builds static.
Reset it alongside the other adapter-derived fields in both places.