Fix the cropped logo with CSS instead of a client-ID override

The avatar used object-fit: cover, which crops a wide wordmark into an
unreadable fragment. Switching to contain fixes that for every client, so
the appwrite-cli special case and its resolver helper are unnecessary.

Hardcoding the CLI's client ID in the console was also the wrong layer:
logoUri is server-owned app-registry data, so a square mark belongs in the
registration upstream. Worse, app IDs are user-supplied, so anyone able to
create an OAuth app on a self-hosted instance could claim `appwrite-cli`
and render official Appwrite branding on a consent screen.

The helper's trim/?? '' normalization was dead too: the {#if} already
covered empty and undefined, and cimdDocumentToApp gates logoUri through
HTTP_URL before it ever reaches the template.

Fold the rule into .avatar rather than a separate img.avatar block. Every
other .avatar is a flex-centered div, so object-fit is inert there and the
padding stays harmless.
This commit is contained in:
harsh mahajan committed 2026-08-17 09:20:25 +05:30
1 parent af5c071394
commit d049860975
4 files changed
+6 -61

No files matched your search

-27
View File
@@ -1,27 +0,0 @@
import { describe, expect, it } from 'vitest';
import { resolveOAuth2AppLogoUrl } from './oauth2-app-logo';
describe('resolveOAuth2AppLogoUrl', () => {
it('uses the square Appwrite icon for the first-party CLI client', () => {
expect(
resolveOAuth2AppLogoUrl({
$id: 'appwrite-cli',
logoUri: 'https://example.com/wordmark.svg'
})
).toBe('/console/logos/appwrite-icon.svg');
});
it('keeps third-party logoUri values', () => {
expect(
resolveOAuth2AppLogoUrl({
$id: 'other-app',
logoUri: 'https://example.com/logo.png'
})
).toBe('https://example.com/logo.png');
});
it('returns an empty string when no logo is available', () => {
expect(resolveOAuth2AppLogoUrl({ $id: 'other-app', logoUri: ' ' })).toBe('');
expect(resolveOAuth2AppLogoUrl(null)).toBe('');
});
});
-18
View File
@@ -1,18 +0,0 @@
import { base } from '$app/paths';
/**
* First-party clients may register a wide wordmark as `logoUri`. Consent and
* outcome avatars are square, so `object-fit: cover` crops those marks into
* unreadable fragments (see #3159 for Appwrite CLI). Prefer the square icon.
*/
const FIRST_PARTY_ICON_CLIENTS = new Set(['appwrite-cli']);
export function resolveOAuth2AppLogoUrl(
app: { $id?: string; logoUri?: string } | null | undefined
): string {
if (app?.$id && FIRST_PARTY_ICON_CLIENTS.has(app.$id)) {
return `${base}/logos/appwrite-icon.svg`;
}
return app?.logoUri?.trim() ?? '';
}
@@ -48,7 +48,6 @@
type ResourcePage,
type ResourceNameMap
} from '$lib/helpers/oauth2-authorization-details';
import { resolveOAuth2AppLogoUrl } from '$lib/helpers/oauth2-app-logo';
import ResourceSelector from './resource-selector.svelte';
export type OAuth2Flow = 'authorization' | 'device';
@@ -111,7 +110,6 @@
);
const redirectHost = $derived(hostnameOf(grant.redirectUri));
const appLogoUrl = $derived(resolveOAuth2AppLogoUrl(app));
const appInitial = $derived((app.name || '?').charAt(0).toUpperCase());
const accountInitial = $derived((accountLabel || '?').charAt(0).toUpperCase());
@@ -495,8 +493,8 @@
<div class="consent">
<header class="header">
<div class="identity">
{#if appLogoUrl}
<img src={appLogoUrl} alt={app.name} class="avatar" />
{#if app.logoUri}
<img src={app.logoUri} alt={app.name} class="avatar" />
{:else}
<div class="avatar placeholder">{appInitial}</div>
{/if}
@@ -907,10 +905,7 @@
flex-shrink: 0;
border: 1px solid var(--border-neutral-strong);
background: var(--bgcolor-neutral-primary);
}
/* Keep wordmarks readable inside the square avatar (cover crops them). */
img.avatar {
/* Wide wordmarks are common as logoUri; cover would crop them. */
object-fit: contain;
padding: 0.4rem;
box-sizing: border-box;
@@ -3,7 +3,6 @@
import { Card, Typography, Icon } from '@appwrite.io/pink-svelte';
import { IconCheck, IconX, IconLockClosed } from '@appwrite.io/pink-icons-svelte';
import { Button } from '$lib/elements/forms';
import { resolveOAuth2AppLogoUrl } from '$lib/helpers/oauth2-app-logo';
import type { OAuth2Flow, OAuth2Outcome } from './consent-card.svelte';
interface Props {
@@ -29,7 +28,6 @@
const approved = $derived(outcome === 'approved');
const appName = $derived(app?.name ?? 'the application');
const appLogoUrl = $derived(resolveOAuth2AppLogoUrl(app));
const appInitial = $derived((app?.name || '?').charAt(0).toUpperCase());
const accountInitial = $derived((accountLabel || '?').charAt(0).toUpperCase());
@@ -55,8 +53,8 @@
<div class="outcome" class:approved>
<header class="header">
<div class="identity">
{#if appLogoUrl}
<img src={appLogoUrl} alt={appName} class="avatar" />
{#if app?.logoUri}
<img src={app.logoUri} alt={appName} class="avatar" />
{:else}
<div class="avatar placeholder">{appInitial}</div>
{/if}
@@ -163,10 +161,7 @@
flex-shrink: 0;
border: 1px solid var(--border-neutral-strong);
background: var(--bgcolor-neutral-primary);
}
/* Keep wordmarks readable inside the square avatar (cover crops them). */
img.avatar {
/* Wide wordmarks are common as logoUri; cover would crop them. */
object-fit: contain;
padding: 0.4rem;
box-sizing: border-box;