mirror of
https://github.com/appwrite/console.git
synced 2026-06-06 19:27:48 +00:00
Address CodeRabbit review comments
- Add ColumnVarchar, ColumnText, ColumnMediumtext, ColumnLongtext to string.svelte column prop type - Update type cast to include ColumnVarchar for size property access - Remove unreachable functions migration alert (shouldRenderGroup always returns false for functions) - Add || undefined fallback to scopes in updateScopes.svelte for consistency Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.5
parent
9b334e9b25
commit
cb0989a476
@@ -132,14 +132,6 @@
|
||||
</script>
|
||||
|
||||
<Layout.Stack gap="l">
|
||||
{#if report && !isVersionAtLeast(version, '1.4.0') && $provider.provider === 'appwrite'}
|
||||
<Alert.Inline status="warning">
|
||||
<svelte:fragment slot="title">Functions not available for import</svelte:fragment>
|
||||
To migrate your functions, update the version of the Appwrite instance you're importing from
|
||||
to a version newer than 1.4
|
||||
</Alert.Inline>
|
||||
{/if}
|
||||
|
||||
{#if error}
|
||||
<Alert.Inline status="error" title="Couldn’t load resources">
|
||||
{#if migrationType === 'provider'}
|
||||
|
||||
+5
-1
@@ -20,6 +20,10 @@
|
||||
limited?: boolean;
|
||||
column:
|
||||
| Models.ColumnString
|
||||
| Models.ColumnVarchar
|
||||
| Models.ColumnText
|
||||
| Models.ColumnMediumtext
|
||||
| Models.ColumnLongtext
|
||||
| Models.ColumnInteger
|
||||
| Models.ColumnFloat
|
||||
| Models.ColumnBoolean
|
||||
@@ -33,7 +37,7 @@
|
||||
limited
|
||||
? undefined
|
||||
: column.type === 'string' || column.type === 'varchar'
|
||||
? (column as Models.ColumnString).size
|
||||
? (column as Models.ColumnString | Models.ColumnVarchar).size
|
||||
: undefined
|
||||
);
|
||||
|
||||
|
||||
+1
-1
@@ -39,7 +39,7 @@
|
||||
logging: $func.logging || undefined,
|
||||
entrypoint: $func.entrypoint || undefined,
|
||||
commands: $func.commands || undefined,
|
||||
scopes: functionScopes as ScopesType[],
|
||||
scopes: (functionScopes as ScopesType[]) || undefined,
|
||||
installationId: $func.installationId || undefined,
|
||||
providerRepositoryId: $func.providerRepositoryId || undefined,
|
||||
providerBranch: $func.providerBranch || undefined,
|
||||
|
||||
Reference in New Issue
Block a user