From cb0989a47697c2c04b8a57160316fec4b093e2d8 Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Fri, 6 Feb 2026 18:52:35 +1300 Subject: [PATCH] Address CodeRabbit review comments - Add ColumnVarchar, ColumnText, ColumnMediumtext, ColumnLongtext to string.svelte column prop type - Update type cast to include ColumnVarchar for size property access - Remove unreachable functions migration alert (shouldRenderGroup always returns false for functions) - Add || undefined fallback to scopes in updateScopes.svelte for consistency Co-Authored-By: Claude Opus 4.5 --- .../(console)/(migration-wizard)/resource-form.svelte | 8 -------- .../table-[table]/rows/columns/types/string.svelte | 6 +++++- .../function-[function]/settings/updateScopes.svelte | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/routes/(console)/(migration-wizard)/resource-form.svelte b/src/routes/(console)/(migration-wizard)/resource-form.svelte index 650a7f10e..4113f12c9 100644 --- a/src/routes/(console)/(migration-wizard)/resource-form.svelte +++ b/src/routes/(console)/(migration-wizard)/resource-form.svelte @@ -132,14 +132,6 @@ - {#if report && !isVersionAtLeast(version, '1.4.0') && $provider.provider === 'appwrite'} - - Functions not available for import - To migrate your functions, update the version of the Appwrite instance you're importing from - to a version newer than 1.4 - - {/if} - {#if error} {#if migrationType === 'provider'} diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte index eecfafe13..fbfa549ae 100644 --- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte +++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte @@ -20,6 +20,10 @@ limited?: boolean; column: | Models.ColumnString + | Models.ColumnVarchar + | Models.ColumnText + | Models.ColumnMediumtext + | Models.ColumnLongtext | Models.ColumnInteger | Models.ColumnFloat | Models.ColumnBoolean @@ -33,7 +37,7 @@ limited ? undefined : column.type === 'string' || column.type === 'varchar' - ? (column as Models.ColumnString).size + ? (column as Models.ColumnString | Models.ColumnVarchar).size : undefined ); diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateScopes.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateScopes.svelte index d5aa8334f..ea8469992 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateScopes.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateScopes.svelte @@ -39,7 +39,7 @@ logging: $func.logging || undefined, entrypoint: $func.entrypoint || undefined, commands: $func.commands || undefined, - scopes: functionScopes as ScopesType[], + scopes: (functionScopes as ScopesType[]) || undefined, installationId: $func.installationId || undefined, providerRepositoryId: $func.providerRepositoryId || undefined, providerBranch: $func.providerBranch || undefined,