swift-server/swift-memcache-gsoc
1
0
Fork 0
mirror of https://github.com/swift-server/swift-memcache-gsoc.git synced 2026-05-03 07:42:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable strict concurrency (#47)

Browse Source 
### Motivation:

Catch potential data races at build time.

### Modifications:

- Enabled strict concurrency checking in the Package.swift and removed
it from the CI flags.

### Result:

Fewer potential data races can sneak in.

### Test Plan

Ran tests locally, did not see any concurrency warnings or errors.
This commit is contained in:
Honza Dvorsky
2024-12-03 14:11:11 +01:00
committed by GitHub
parent e578b9ec90
commit 350450f5cd
4 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/main.yml
+2 -2
View File
@@ -11,8 +11,8 @@ jobs:
name: Unit tests
uses: ./.github/workflows/unit_tests.yml
with:
linux_5_9_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete"
linux_5_10_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete"
linux_5_9_arguments_override: "--explicit-target-dependency-import-check error"
linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
linux_6_0_arguments_override: "--explicit-target-dependency-import-check error"
linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error"
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error"
.github/workflows/pull_request.yml
+2 -2
View File
@@ -15,8 +15,8 @@ jobs:
name: Unit tests
uses: ./.github/workflows/unit_tests.yml
with:
linux_5_9_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete"
linux_5_10_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete"
linux_5_9_arguments_override: "--explicit-target-dependency-import-check error"
linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
linux_6_0_arguments_override: "--explicit-target-dependency-import-check error"
linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error"
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error"
.gitignore
+1
View File
@@ -9,3 +9,4 @@ DerivedData/
.netrc
Package.resolved
.*.sw?
.vscode
Package.swift
+6
View File
@@ -57,3 +57,9 @@ let package = Package(
),
]
)
for target in package.targets {
var settings = target.swiftSettings ?? []
settings.append(.enableExperimentalFeature("StrictConcurrency=complete"))
target.swiftSettings = settings
}