swift-server/swift-aws-lambda-runtime
1
0
Fork 0
mirror of https://github.com/swift-server/swift-aws-lambda-runtime.git synced 2026-05-03 07:22:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove mock writeStatusAndHeaders shadowing in writer tests (#657)

Browse Source 
<!--- Provide a general summary of your changes in the Title above -->

## Issue \#
<!--- If it fixes an issue, please link to the issue here -->
N/A

## Description of changes
<!--- Why is this change required? What problem does it solve? -->
- Several test mocks in `LambdaResponseStreamWriter+HeadersTests.swift`
implemented their own `writeStatusAndHeaders(...)`.
- This change is required to make the tests validate actual behavior
instead of mock-only behavior.

## New/existing dependencies impact assessment, if applicable
<!--- No new dependencies were added to this change. -->
<!--- If any dependency was added / modified / removed,
THIRD-PARTY-LICENSES must be updated accordingly. -->

## Conventional Commits
<!--- Please use conventional commits to let us know what kind of change
this is.-->
<!--- More info can be found here:
https://www.conventionalcommits.org/en/v1.0.0/-->

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
This commit is contained in:
Manoj Mahapatra
2026-03-04 10:27:18 -08:00
committed by GitHub
parent 3e528b2944
commit 3772bd6352
1 changed files with 0 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Tests/AWSLambdaRuntimeTests/LambdaResponseStreamWriter+HeadersTests.swift
-44
View File
@@ -542,22 +542,6 @@ final class MockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
private(set) var isFinished = false
private(set) var hasCustomHeaders = false
// Add a JSON string with separator for writeStatusAndHeaders
func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
let jsonString = "{\"statusCode\":200,\"headers\":{\"Content-Type\":\"text/plain\"}}"
buffer.writeString(jsonString)
// Add null byte separator
let nullBytes: [UInt8] = [0, 0, 0, 0, 0, 0, 0, 0]
buffer.writeBytes(nullBytes)
try await self.write(buffer, hasCustomHeaders: true)
}
func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writtenBuffers.append(buffer)
self.hasCustomHeaders = hasCustomHeaders
@@ -587,15 +571,6 @@ final class FailingMockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
self.failOnWriteCall = failOnWriteCall
}
func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}
func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writeCallCount += 1
self.hasCustomHeaders = hasCustomHeaders
@@ -698,15 +673,6 @@ final class TrackingLambdaResponseStreamWriter: LambdaResponseStreamWriter {
private(set) var isFinished = false
private(set) var hasCustomHeaders = false
func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}
func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writeCallCount += 1
self.hasCustomHeaders = hasCustomHeaders
@@ -733,16 +699,6 @@ final class CustomBehaviorLambdaResponseStreamWriter: LambdaResponseStreamWriter
private(set) var isFinished = false
private(set) var hasCustomHeaders = false
func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
customBehaviorTriggered = true
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}
func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
// Trigger custom behavior on any write
customBehaviorTriggered = true