libimobiledevice/libimobiledevice-glue
1
0
Fork 0
mirror of https://github.com/libimobiledevice/libimobiledevice-glue.git synced 2026-04-17 19:27:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

socket/win32: Use calloc where applicable in getifaddrs implementation

Browse Source 
This should prevent crashes like the one mentioned in #12 which are caused
by releasing an invalid pointer (due to uninitialized memory).
This commit is contained in:
Nikias Bassen
2024-10-21 12:27:40 +02:00
parent 69f98e35d6
commit 1085e461a5
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/socket.c
+3 -4
View File
@@ -669,7 +669,7 @@ static int getifaddrs(struct ifaddrs** ifap)
}
if (!ifa) {
ifa = malloc(sizeof(struct ifaddrs));
ifa = calloc(1, sizeof(struct ifaddrs));
if (!ifa) {
errno = ENOMEM;
free(pAddresses);
@@ -678,7 +678,7 @@ static int getifaddrs(struct ifaddrs** ifap)
*ifap = ifa;
ifa->ifa_next = NULL;
} else {
struct ifaddrs* ifanew = malloc(sizeof(struct ifaddrs));
struct ifaddrs* ifanew = calloc(1, sizeof(struct ifaddrs));
if (!ifanew) {
freeifaddrs(*ifap);
free(pAddresses);
@@ -708,8 +708,7 @@ static int getifaddrs(struct ifaddrs** ifap)
memcpy(ifa->ifa_addr, unicast->Address.lpSockaddr, unicast->Address.iSockaddrLength);
/* netmask */
ifa->ifa_netmask = (struct sockaddr*)malloc(sizeof(struct sockaddr_storage));
memset(ifa->ifa_netmask, 0, sizeof(struct sockaddr_storage));
ifa->ifa_netmask = (struct sockaddr*)calloc(1, sizeof(struct sockaddr_storage));
/* store mac address */
if (adapter->PhysicalAddressLength == 6) {