faye/faye-redis-node
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make the destroyClient method make all its writes in a single MULTI operation.

Browse Source
This commit is contained in:
James Coglan
2014-06-05 21:42:07 +01:00
parent 24f800c134
commit fee61a8d65
1 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
faye-redis.js
+18 -17
View File
@@ -81,28 +81,29 @@ Engine.prototype = {
destroyClient: function(clientId, callback, context) {
var self = this;
this._redis.zadd(this._ns + '/clients', 0, clientId, function() {
self._redis.smembers(self._ns + '/clients/' + clientId + '/channels', function(error, channels) {
var n = channels.length, i = 0;
if (i === n) return self._afterSubscriptionsRemoved(clientId, callback, context);
this._redis.smembers(this._ns + '/clients/' + clientId + '/channels', function(error, channels) {
var multi = self._redis.multi();
channels.forEach(function(channel) {
self.unsubscribe(clientId, channel, function() {
i += 1;
if (i === n) self._afterSubscriptionsRemoved(clientId, callback, context);
});
});
multi.zadd(self._ns + '/clients', 0, clientId);
channels.forEach(function(channel) {
multi.srem(self._ns + '/clients/' + clientId + '/channels', channel);
multi.srem(self._ns + '/channels' + channel, clientId);
});
});
},
multi.del(self._ns + '/clients/' + clientId + '/messages');
multi.zrem(self._ns + '/clients', clientId);
multi.publish(self._closeChannel, clientId);
multi.exec(function(error, results) {
channels.forEach(function(channel, i) {
if (results[2 * i + 1] !== 1) return;
self._server.trigger('unsubscribe', clientId, channel);
self._server.debug('Unsubscribed client ? from channel ?', clientId, channel);
});
_afterSubscriptionsRemoved: function(clientId, callback, context) {
var self = this;
this._redis.del(this._ns + '/clients/' + clientId + '/messages', function() {
self._redis.zrem(self._ns + '/clients', clientId, function() {
self._server.debug('Destroyed client ?', clientId);
self._server.trigger('disconnect', clientId);
self._redis.publish(self._closeChannel, clientId);
if (callback) callback.call(context);
});
});